fix: POSIX compatible script to install #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the installation script to be POSIX-compatible by replacing Bash-specific syntax with portable shell alternatives, ensuring the script can run on systems using different shells like sh, dash, or ash.
Key Changes:
- Replaced Bash array syntax with POSIX-compatible positional parameters for iterating user paths
- Converted conditional grep pattern matching to case statement for checking PATH
- Added CI workflow tests to verify installation using both the GitHub Action and the shell script directly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script/install.sh | Converted Bash-specific constructs (arrays, grep conditionals) to POSIX-compliant alternatives |
| .github/workflows/ci.yml | Added two test jobs to validate installation via action and script execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sichan-vonage
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.