Skip to content

Conversation

@driesvints
Copy link
Contributor

@driesvints driesvints commented Feb 11, 2022

Description

Allow support for psr/log v3.0

Motivation and Context

Atm, this is preventing people from upgrading to vonage-notification-channel when they have psr/log installed: laravel/vonage-notification-channel#56

How Has This Been Tested?

I'm relying on this library's test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #310 (5ea884f) into main (c9ca054) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #310   +/-   ##
=========================================
  Coverage     82.18%   82.18%           
  Complexity     1929     1929           
=========================================
  Files           157      157           
  Lines          5051     5051           
=========================================
  Hits           4151     4151           
  Misses          900      900           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ca054...5ea884f. Read the comment docs.

@SecondeJK SecondeJK merged commit afc7333 into Vonage:main Feb 11, 2022
@driesvints driesvints deleted the patch-1 branch February 11, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants