Skip to content

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 1, 2020

Also:

  • Upgrade syntax for Python 3.6+: hello f-strings!
  • Remove Python 2 and 3.4 imports
  • Update pre-commit and apply changes
  • Add pre-commit lint to GitHub Actions to make sure it stays in sync

@Lczajkowski Lczajkowski requested a review from superdiana October 8, 2020 11:10
@superdiana superdiana changed the base branch from master to v3-0-release October 8, 2020 13:48
@superdiana
Copy link
Contributor

Awesome work @hugovk!! i changed the base branch to v3.0 release. There are some conflicts to resolve, mostly with supporting sms, verify and voice only with their independent classes and removing these methods from the client. Also with tests. Would you be interested on continuing the conflict resolution?

@hugovk
Copy link
Contributor Author

hugovk commented Oct 8, 2020

Oops, wrong branch! Will update!

@hugovk
Copy link
Contributor Author

hugovk commented Oct 8, 2020

Updated!

@superdiana superdiana merged commit 01edb47 into Vonage:v3-0-release Oct 8, 2020
@hugovk hugovk deleted the rm-eol branch October 8, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants