Implement Unicode support for RL.Net #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes marshalling empty strings from C++ to .Net side
dwaijam
reviewed
Apr 1, 2019
| @@ -65,6 +65,11 @@ API int LiveModelInit(livemodel_context_t* context, reinforcement_learning::api_ | |||
|
|
|||
| API int LiveModelChooseRank(livemodel_context_t* context, const char * event_id, const char * context_json, reinforcement_learning::ranking_response* resp, reinforcement_learning::api_status* status) | |||
| { | |||
| if (event_id == nullptr) | |||
There was a problem hiding this comment.
This check looks unnecessary
There was a problem hiding this comment.
Ah, good catch. Under the check, it was chaining to the wrong method in the nullptr case. It is supposed to go to the auto-generate EventId code.
jackgerrits
approved these changes
Apr 2, 2019
* Fixes output of rl.net.cli.test to match the rest of the dotnet project output paths * Change RoundtripTest to use NativeMethods.StringMarshallingFunc to test that it is symmetric with NativeMethods.StringEncoding * Changes pseudoloc strings to include the bit that crashed iOS messaging as a known example of potential issues with Unicode * Removes commented out configuration / code * Remove superfluous Run_LiveModelChooseRankXYZ test calls (from Test_LiveModel_ChooseRankE2E, they are run in Test_ListModel_ChooseRank below it) * Add a test to ensure non-nullptr arrays that begin with \0 are marshalled properly as an empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first built the .Net bindings for rlclientlib we make a decision to only support ASCII. (VowpalWabbit/vowpal_wabbit#1601). This will behave incorrectly when sending text with code points outside of ASCII.
This change implements proper marshalling using UTF8.