Skip to content
Browse files

Force OSX to build .so files for python (#2061)

  • Loading branch information...
peterychang authored and jackgerrits committed Sep 4, 2019
1 parent ee1b88e commit 97043b861b12967cbd9977b885f95d79c895209c
Showing with 3 additions and 0 deletions.
  1. +3 −0 python/CMakeLists.txt
@@ -40,7 +40,10 @@ set_target_properties(pylibvw PROPERTIES PREFIX "")
if (NOT WIN32)
# Windows links dynamically
target_compile_definitions(pylibvw PUBLIC BOOST_PYTHON_STATIC_LIB)
# OSX builds a .dylib and then attempts to find a .so. Just build a .so file and things work
set_target_properties(pylibvw PROPERTIES SUFFIX ".so")
# Force Windows to build with a .pyd extension
set_target_properties(pylibvw PROPERTIES SUFFIX ".pyd")
target_link_libraries(pylibvw PUBLIC ${PYTHON_LIBRARIES} Boost::system Boost::python${BOOST_PY_VERSION_SUFFIX} vw allreduce)

0 comments on commit 97043b8

Please sign in to comment.
You can’t perform that action at this time.