Skip to content
Permalink
Branch: master
Commits on Feb 5, 2019
  1. Fix model file parser for proper treatment of negative-valued options (

    lokitoth authored and JohnLangford committed Feb 5, 2019
    …#1742)
    
    * Fix model file parser for proper treatment of negative-valued options
    
    The previous program options changes introduced an issue where models
      that have a stored value of the form '-' + '<digit>' will have the
      options merge logic incorrectly treat this value as a key and merge
      it in as "---<digit>", which then breaks the final parser pass.
    
    The fix is to add a rule that option key identifiers cannot start from
      a digit (similar rules to variable identifiers), and treat it as a
      value when running the merge logic.
    
    * Fix typos and misalignment in comments
    
    * Fix formatting using clang-format
    
    * I manually undid the merge of the four conditions in the check at
       parse_args.cc:1426, since it seems more readable with more whitespace
Commits on Jan 30, 2019
  1. Fix file enocding for .rc files (#1734)

    lokitoth authored and JohnLangford committed Jan 30, 2019
  2. Scripts for running tests and generating NuGet packages (#1732)

    lokitoth authored and JohnLangford committed Jan 30, 2019
    * Scripts for running tests and generating NuGet packages
    
    * Creates a test script to run C smoke tests, C++ unit tests and C# UTs
    * Creates a package script to generate NuGet packages
    * Updates the nuspec files to properly support injecting paths into them
    
    Note: The test script is currently designed to be used by humans, and it
      may fail to error out a CI/CD process that simply executes the script.
    
    * Empty commit to trigger CI
Commits on Jan 29, 2019
  1. Fix warnings in Windows MSVC x64 build (#1730)

    lokitoth authored and JohnLangford committed Jan 29, 2019
    * Fix warnings in Windows MSVC x64 build
    
    * Fixes bool inequality comparison warning
    * Annotates rapidjson.h as unmanaged when compiling with /clr under MSVC
    
    Note: This does not address a warning about code analysis ruleset not
       found in some cases, as well as an issue with GitLink and the T4 tool
    
    * Add comments referencing documentation for /clr warning fix
Commits on Jan 23, 2019
  1. Create Windows build scripts and update instructions (#1721)

    lokitoth authored and jackgerrits committed Jan 23, 2019
    * Create windows build scripts and clean up readme
    
    * Update AppVeyor to use new scripts
    
    * Fix bad set command in appveyor.yml
Commits on Jan 22, 2019
  1. Make cbify reduction respect is_learn parameter (#1722)

    lokitoth authored and JohnLangford committed Jan 22, 2019
Commits on Nov 2, 2018
  1. Update rl.net.native to consume changed rlclientlib interface (#1665)

    lokitoth authored and jackgerrits committed Nov 2, 2018
    * ranking_iterator => const_iterator
    * extract a POD base struct for action_prob (action_prob_d) which can
      be exposed under extern "C" {} constraints
Commits on Oct 24, 2018
  1. Update unit test for corrected observation parsing semantics

    lokitoth committed Oct 24, 2018
  2. Final fixes to C# RLDriver for validation against C++ baseline

    lokitoth committed Oct 24, 2018
Commits on Oct 23, 2018
Commits on Oct 19, 2018
  1. Make VW setup projects buildable from the command-line (#1646)

    lokitoth authored and JohnLangford committed Oct 19, 2018
    * Update vw .Net Assembly Version to match release version
    
    * Fix setup projects to be buildable and create setup solution
    
    * Empty commit to kick AppVeyor
  2. Merge branch 'master' into cs-simulator

    lokitoth committed Oct 19, 2018
Commits on Oct 18, 2018
  1. Harden rllib's test_cpp in validation mode (#1645)

    lokitoth authored and jackgerrits committed Oct 18, 2018
    * Add command-line option to sleep between loop cycles
    
    * Change interval check to be a range comparison
    
    * Add background error callback
    
    This will enable us to avoid getting into permanent error mode on the
    first background error that gets hit.
  2. Merge branch 'master' into cs-simulator

    lokitoth committed Oct 18, 2018
  3. Merge branch 'master' into cs-simulator

    lokitoth committed Oct 18, 2018
  4. Implement RL History Replay in Rl.Net.Cli

    lokitoth committed Oct 18, 2018
    * Refactor generic RL Driver out of RL Simulator
    * Implement IDriverStepProvider to replay dsJson lines
  5. Merge branch 'master' into cs-simulator

    lokitoth committed Oct 18, 2018
Commits on Oct 9, 2018
  1. Remove checked-in secrets

    lokitoth committed Oct 9, 2018
  2. Expose ActionProbabilities list from RankingResponse

    lokitoth committed Oct 9, 2018
  3. Add launchSettings.json with nativeDebugging enabled

    lokitoth committed Oct 9, 2018
  4. Binding json-based ReportOutcome

    lokitoth committed Oct 9, 2018
Commits on Oct 5, 2018
  1. Fix ApiStatus in RL.Net and JSON generation in RL.Net.Cli

    lokitoth committed Oct 5, 2018
    * Previous tests of RL.Net were all done against an existing model which
      uses a different parser for the decisionContext json. This parser is
      much more strict and disallows single-quotes as string delimiters.
      This causes parsing to fail using the JSON generated by RL.Net.Cli.
    
    * Similarly, previous tests of ApiStatus always called GetMessage right
      exiting, which prevented us catching a bug where P/Invoke attempts to
      delete the returned native string as part of converting it. The
      solution is to return an IntPtr and run the string conversion by hand.
  2. Implement statistics collection and reporting in C# RLSimulator

    lokitoth committed Oct 4, 2018
Commits on Oct 4, 2018
  1. RLLib C# Bindings (#1601)

    lokitoth authored and JohnLangford committed Oct 4, 2018
    * C# Bindings: Native Object lifecycle management and Configuration
    
    * E2E command-line build and P/Invoke (Windows)
    * Stand up lifecycle contract in NativeObject (todo: simplify verbosity)
    * Bind Configuration lifecycle and JSON-initialization
    
    * Address PR feedback
    
    * Removes unneeded "global" functions in rl.net.native
    * Changed Debug traces in Rl.Net's NativeObject to be Debug-only
    
    * Implement remaining C# bindings
    
    * Bind ApiStatus
    * Bind LiveModel
    * Bind RankingResponse
    
    * Change string marshalling to be ANSI - need to figure out whether our
    json parser supports unicode in some manner.
    
    * Updated to lastest master and build-cleanup; addressed feedback comments
    
    * Switched rl.net.cli to new style of project
    * Removed unneeded files
    * Removed namespace shorthand for readability
    * Fixed some spelling issues and typos
    
    * PR and typo fixes for C# bindings
    
    * PR Comment Changes: Update naming for consistency
    
    * Final pass over todos
    
    * Update RL.Net.Native internal interface for RL Lib API change.
    
    * Re-trigger build which failed due to timeout
Commits on Sep 22, 2018
  1. Clean windows build and unify output paths (#1599)

    lokitoth authored and JohnLangford committed Sep 22, 2018
    * Remove Setup and Azure projects from solution
    
    * The Azure projects are not well-maintained; they need retargetting / rethinking
    * The Setup project requires WiX installed, and this does not seem valuable to most people building VW
    
    * Remove Azure dependency from C# Binding unit tests
    
    * Enable command-line msbuild for vcpkg-dependent projects
    
    * This depends on VcpkgIntegration environment variable / project
       property set to the .targets file from msbuild integration:
          (VcPkgRoot)/scripts/buildsystems/msbuild/vcpkg.targets.
    
       If it is not present, the behaviour will be as before this change,
       demanding VS-level integration.
    
    * Simplify and rename vs static library project
    
    * Rename vw_dynamic => vw_core
    * Manually simplify the project and reconcile the outputs to
       $(SolutionDir)\out\<target\int>\...
    * Update dependent projects
    
    * Simplify vw executable project
    
    * Enabled multi-threaded compilation
    * Also adds $(ProjectName) to int-path to avoid collisions
    
    * Fix "malformed xml in xmldoc comment" warning
    
    * Simplify libvw project file
    
    * Fix typo in vw exe project
    
    * Simplify c_test project
    
    * Simplify unit_test.vcxproj and unify output/intermediate paths
    
    * Add xcopy step to place boost unit test dll
    
    * Remove VisualLeakDetector-based projects
    
    They do not currently build, and require an installed component to work
    properly.
    
    * Simplify vw clr project and unify outputs
    
    * Remove unused deploy_vw project from build
    
    * Remove unused DebugLeakCheck configuration
    
    * Simplify C# projects and unify outputs
    
    * Update for PR comments
    
    * Update unittest project to pull the right package under x86
    
    None of these change the behaviour of the build after the previous set
    of changes, just removes non-building projects:
    * Delete superfluous vcsproj files (for VLD integration)
    * Remove VLD package reference
You can’t perform that action at this time.