New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Windows build scripts and update instructions #1721

Merged
merged 4 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@lokitoth
Copy link
Collaborator

lokitoth commented Jan 22, 2019

  • Creates restore and build scripts with support for custom toolchain integration
  • Updates instructions for building on Windows (includes instructions for VS2017)
  • Changes AppVeyor to use new build scripts
@@ -0,0 +1,41 @@
## Windows specific info

This document details differences in pre-requisites and building instructions under Windows.

This comment has been minimized.

@jackgerrits

jackgerrits Jan 22, 2019

Member

Can this in be added in the wiki rather than here? https://github.com/VowpalWabbit/vowpal_wabbit/wiki/Dependencies

This comment has been minimized.

@lokitoth

lokitoth Jan 22, 2019

Author Collaborator

Sure; I was just trying to be parallel to README.md. Keep in both, like for Linux?

This comment has been minimized.

@JohnLangford

JohnLangford Jan 22, 2019

Collaborator

Keeping it in both seems good. More ideally, we'd sync the wiki's version to the source code version.

This comment has been minimized.

@jackgerrits

jackgerrits Jan 23, 2019

Member

So the readme is a bit out of date at the moment, I've done work to try and make sure the wiki is up to date. I've utilized several pages in the wiki to make it a bit simpler. I was planning on making the front page readme a bit simpler and just using it to explain VW's mission and why use it, then link into the wiki for instructions

@lokitoth

This comment has been minimized.

Copy link
Collaborator Author

lokitoth commented Jan 22, 2019

Closes #1691

@JohnLangford

This comment has been minimized.

Copy link
Collaborator

JohnLangford commented Jan 23, 2019

@jackgerrits

This comment has been minimized.

Copy link
Member

jackgerrits commented Jan 23, 2019

Totally agree, plus there's the added benefit of pull requests for changes when they are in files. So we can either migrate the existing wiki docs to a folder in the vowpalwabbit repo, or we can utilize the docs repo I recently created to host the rl_client docs. (See here https://vowpalwabbit.github.io/docs/, but this removes the benefit of automatically having it available locally for offline use) Or we can wait until the website is ready and think about how the pages fit in there? The wiki is useful for the sidebar aswell

@jackgerrits jackgerrits merged commit 06f09ad into VowpalWabbit:master Jan 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment