Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coveralls inside docker #1847

Merged
merged 5 commits into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@yannstad
Copy link
Collaborator

commented Apr 15, 2019

Reactivate code coverage reports with coveralls (last run was in Nov 2017).
Fix issue #1763

@yannstad

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 15, 2019

@JohnLangford
I replicated the CI pipeline on my github, and was able to submit successfully the request to coveralls.io, doing exactly the same change.

When the change is applied here, the Travis job fails to submit the request to coveralls (see the end of Travis logs):
Couldn't find a repository matching this job

I suspect the issue is caused by the coveralls repo token, that may be out of date. Can you please try to logout/login from coveralls.io in order to refresh the sync between coveralls/github/travis ?

yannstad added some commits Apr 17, 2019

@JohnLangford JohnLangford merged commit aeddf73 into VowpalWabbit:master Apr 18, 2019

8 checks passed

LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-coveralls at 72.988%
Details
@JohnLangford

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Merged, thanks :-)

@yannstad yannstad deleted the yannstad:fix-coveralls branch Apr 18, 2019

jackgerrits added a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019

Run coveralls inside docker (VowpalWabbit#1847)
* Run coveralls inside docker

* simplify docker arguments

* report coverage for vw and explore lib only

* Update coveralls badge in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.