Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up broken python3 vcxproj files #1854

Merged

Conversation

Projects
None yet
2 participants
@peterychang
Copy link
Collaborator

commented Apr 25, 2019

I'm leaving in the python27 vcxproj files since the CMake/vcpkg method requires a manual edit of a vcpkg CONTROL file.
microsoft/vcpkg#3495

I'll remove the old workflow once I can find a programmatic way of handling it

@peterychang peterychang requested a review from JohnLangford Apr 25, 2019

> python setup.py --vcpkg-root=[vcpkg-dir] install

.. _experimental Windows CMake build: https://github.com/VowpalWabbit/vowpal_wabbit/blob/master/README.Windows.md#experimental-cmake-build

This comment has been minimized.

@jackgerrits

This comment has been minimized.

Copy link
Member

commented May 1, 2019

This seems like a good opportunity for us to contribute to vcpkg, the change seems easy and it will help us a lot here

peterychang and others added some commits May 6, 2019

peterychang
Merge branch 'python3_windows_cleanup' of github.com:peterychang/vowp…
…al_wabbit into python3_windows_cleanup
peterychang
Revert "merging with master"
This reverts commit d474b3e.
@jackgerrits

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Looks like the failures are due to the fact the submodule was removed in the merge

@jackgerrits jackgerrits merged commit 04cb225 into VowpalWabbit:master May 6, 2019

6 of 8 checks passed

LGTM analysis: C# Analysis failed (could not build the base commit (aeb90b0))
Details
LGTM analysis: C/C++ Analysis failed (could not build the base commit (aeb90b0))
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.956%
Details

jackgerrits added a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019

cleaning up broken python3 vcxproj files (VowpalWabbit#1854)
* cleaning up broken python3 vcxproj files

* Update URL to wiki instead of README

* merging with master

* Revert "merging with master"

This reverts commit d474b3e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.