Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Version and Tag override for NuGet pack #1870

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@lokitoth
Copy link
Collaborator

commented May 9, 2019

This provides a mechanism to insert version/tag during the CI/CD pipeline (thereby inserting a version generated by the pipeline).

Longer-term this will be handed by a "version generation" step, which will read the target version from a file, and create the appropriate artifacts (config.h, build.props, etc.) to be used by the appropriate build systems to inject the version. In the short term, this unblocks work on release pipeline for Windows artifacts.

@lokitoth lokitoth merged commit a10ae96 into master May 10, 2019

9 checks passed

LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.956%
Details

@lokitoth lokitoth deleted the dev/Enable-NugetVersionTagOverride branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.