Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource.rc encoding #1896

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
2 participants
@lokitoth
Copy link
Collaborator

commented May 30, 2019

Some time ago we changed the *.rc files encoding to request git to set it to the proper encoding: UTF-16LE. Unfortunately, the autocrlf breaks this conversion, which breaks the version stamping. The fix is to admit that git does not deal with UTF-16 in a functional way, and just treat resource files as binary.

@lokitoth lokitoth force-pushed the lokitoth:dev/fix_resource_rc branch 2 times, most recently from 31294d1 to 0732884 May 30, 2019

@lokitoth lokitoth force-pushed the lokitoth:dev/fix_resource_rc branch from 0732884 to 7b8652f May 30, 2019

@jackgerrits

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thanks for fixing this Jacob!

@jackgerrits jackgerrits merged commit 9206466 into VowpalWabbit:master May 31, 2019

8 checks passed

LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.366%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.