Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to to tovw to clarify usage #1999

Merged

Conversation

@jackgerrits
Copy link
Member

commented Aug 7, 2019

Fixes #1472

@peterychang

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

lgtm

@gramhagen
Copy link
Contributor

left a comment

looks good

@jackgerrits jackgerrits merged commit d5ba078 into VowpalWabbit:master Aug 8, 2019

10 of 11 checks passed

MacOS CI Build #20190807.10 failed
Details
LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Linux CI Build #20190807.10 succeeded
Details
Windows CI Build #20190807.10 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.019%
Details

@jackgerrits jackgerrits deleted the jackgerrits:jagerrit/add_comment_to_tovw branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.