Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force OSX to build .so files for python #2061

Merged

Conversation

@peterychang
Copy link
Collaborator

commented Aug 27, 2019

No description provided.

@@ -40,7 +40,10 @@ set_target_properties(pylibvw PROPERTIES PREFIX "")
if (NOT WIN32)
# Windows links dynamically
target_compile_definitions(pylibvw PUBLIC BOOST_PYTHON_STATIC_LIB)
# OSX builds a .dylib and then attempts to find a .so. Just build a .so file and things work
set_target_properties(pylibvw PROPERTIES SUFFIX ".so")

This comment has been minimized.

Copy link
@jackgerrits

jackgerrits Aug 27, 2019

Member

Should we check for OSX specifically?

This comment has been minimized.

Copy link
@peterychang

peterychang Sep 4, 2019

Author Collaborator

Both linux and OSX need .so extensions. It should(?) be good enough to check for !Windows here

This comment has been minimized.

Copy link
@jackgerrits

jackgerrits Sep 4, 2019

Member

Sounds good!

@jackgerrits jackgerrits merged commit 97043b8 into VowpalWabbit:master Sep 4, 2019

10 of 11 checks passed

MacOS CI Build #20190904.2 failed
Details
LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Linux CI Build #20190904.2 succeeded
Details
Windows CI Build #20190904.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 74.415%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.