Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate cache reading failures #2062

Merged

Conversation

@jackgerrits
Copy link
Member

commented Aug 27, 2019

  • ClosingTest had to be updated, as it tries to read an empty file and is actually a failure

Fixes #1774

jackgerrits added 4 commits Aug 27, 2019
Propagate cache reading failures
- ClosingTest had to be updated, as it tries to read an empty file and is actually a failure

@jackgerrits jackgerrits merged commit a4ff3d5 into VowpalWabbit:master Aug 30, 2019

10 of 11 checks passed

MacOS CI Build #20190830.5 failed
Details
LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Java No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Linux CI Build #20190830.5 succeeded
Details
Windows CI Build #20190830.5 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 74.415%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.