Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LGTM Java build issues #2063

Merged
merged 7 commits into from Aug 29, 2019

Conversation

@jackgerrits
Copy link
Member

commented Aug 27, 2019

Fixes #1856

jackgerrits added 6 commits Aug 27, 2019
@jackgerrits

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

LGTM reports failure if either the base or child fail to build. Master is still failing (this pr fixes that), but the child now works

image

@jackgerrits jackgerrits merged commit d2db164 into VowpalWabbit:master Aug 29, 2019

9 of 11 checks passed

LGTM analysis: Java Analysis failed (could not build the base commit (4848dc4))
Details
MacOS CI Build #20190829.5 failed
Details
LGTM analysis: C# No new or fixed alerts
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
Linux CI Build #20190829.5 succeeded
Details
Windows CI Build #20190829.5 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 74.346%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.