Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove io_buf::init() #2073

Merged
merged 4 commits into from Sep 4, 2019

Conversation

@jackgerrits
Copy link
Member

commented Aug 30, 2019

This function allowed for memory leaks if called, and was not necessary.

jackgerrits added 4 commits Aug 30, 2019
@peterychang

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

LGTM

@jackgerrits jackgerrits merged commit d05599e into VowpalWabbit:master Sep 4, 2019

9 of 11 checks passed

MacOS CI Build #20190904.8 failed
Details
coverage/coveralls Coverage decreased (-0.006%) to 74.409%
Details
LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Linux CI Build #20190904.8 succeeded
Details
Windows CI Build #20190904.8 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.