Skip to content

Voyager1

Organizations

@xbmc
@Voyager1

is there anything else left to do, or can it pulled in?

@Voyager1

need to #include < atomic > (compile error on Windows)

Voyager1 deleted branch deinterlace-fix-jarvis at Voyager1/xbmc
Voyager1 deleted branch fix-multipartstack at Voyager1/xbmc
Voyager1 deleted branch jarvis-fix-multipartstack at Voyager1/xbmc
Voyager1 deleted branch jarvis-fix-dvd at Voyager1/xbmc
Voyager1 opened pull request xbmc/xbmc#8998
@Voyager1
[DVD menus] [backport] Fix two cases of invisible dvd overlays
2 commits with 7 additions and 11 deletions
Voyager1 opened pull request xbmc/xbmc#8997
@Voyager1
fix multipart stack
1 commit with 1 addition and 1 deletion
Voyager1 commented on pull request xbmc/xbmc#8939
@Voyager1

test done - works great. +1

Voyager1 commented on pull request xbmc/xbmc#8939
@Voyager1

I'll do a quick check later today and let you know.

Voyager1 commented on pull request xbmc/xbmc#8935
@Voyager1

thanks - testing done and all good! you guys rock :-) Note that I combined it with @afedchin dxva deinterlacing fix #8939

Voyager1 commented on pull request xbmc/xbmc#8939
@Voyager1

thanks - testing done and all good!

Voyager1 commented on commit afedchin/xbmc@e2d1c8e2ea
@Voyager1

Sure that's ok

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

hey! that worked... setting deinterlacing to off does the trick

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

SW decoding indeed. Renderer doesn't matter (same with DXVA / PS and Software renderer).

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

I still managed to get the exception with the move. First-chance exception at 0x023C9F5A in Kodi.exe: 0xC0000005: Access violation reading location…

@Voyager1

tried this (move ManageTextures() from Configure to Update) - not much difference...

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

When I add #8935 the situation changes: sometimes the pink stills are gone (not always - seems random) and when that is the case, menu does not res…

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

I reverted only the WinRenderer commit and that is already slightly better. Now the menus are "working" but I still get the stills as full-screen P…

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

2 things: time (may take a while) and while I can try you're obviously closer to the VideoPlayer code... Since I provided the examples that break, …

Voyager1 commented on commit afedchin/xbmc@e2d1c8e2ea
@Voyager1

however, if I only revert #8886, deinterlacing works fine.

Voyager1 commented on commit afedchin/xbmc@e2d1c8e2ea
@Voyager1

if I revert #8886 (as it breaks DVD menus) and I add this PR, somehow deinterlacing is also broken.

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

update and confirmation: I refined my analysis and narrowed it down to ONLY this PR (reverted with very minimal conflict resolution).

Voyager1 commented on pull request xbmc/xbmc#8886
@Voyager1

Testing did apparently not include DVD menus... unfortunately since this PR they are broken. I used the SPONGEBOB https://www.dropbox.com/s/hquzbke…

Voyager1 commented on pull request xbmc/xbmc#8929
@Voyager1

keep the hints.dvd - many DVDs don't decode well in HW on Windows (green screen) - at least until we find a way to fix the decoding problem!

Voyager1 commented on commit afedchin/xbmc@e2d1c8e2ea
@Voyager1

The comment has since been removed.

Voyager1 commented on commit afedchin/xbmc@e2d1c8e2ea
@Voyager1

hi @afedchin - I've tested this commit and there are lots of "green screen" video decoding issues. Many DVDs don't support being hardware decoded. …

Voyager1 commented on pull request xbmc/xbmc#8891
@Voyager1

@ace20022 - no I have only contributed to things like debugging and serialstring (for disc resume). re. your questions, I can always try :-)

Something went wrong with that request. Please try again.