Voyager1

Organizations

@xbmc
Voyager1 commented on pull request xbmc/xbmc#7195
@Voyager1

@ace20022 - I have now tested, with and without this PR, a few DVD (ISOs) and it seems to work fine, just like I described above.

Voyager1 commented on pull request xbmc/xbmc#7195
@Voyager1

The seek from paused state works fine as is with DVDs. How I tested - I used the June 3rd nightly, played an ISO dvd file, enable mouse input, paus…

Voyager1 commented on pull request xbmc/xbmc#7228
@Voyager1

is this a permanent issue as of Windows 8 or do we get rid of that once we pull the DX11 code in?

Voyager1 commented on pull request xbmc/xbmc#7225
@Voyager1

+1 (already reviewed)

Voyager1 commented on pull request xbmc/xbmc#7195
@Voyager1

sorry - didn't see this one - please let me test this and I'll report back.

Voyager1 commented on pull request xbmc/xbmc#7190
@Voyager1

I think I finally got it - I didn't see the recursion within DVDPlayer::AddSubtitleFile. Assuming that CDVDSubtitleStream is for text-base (like sr…

Voyager1 commented on pull request xbmc/xbmc#7190
@Voyager1

So, checking my understanding: originally the code checked for an idx file, and if that existed, it would add the sub file. Apparently there was an…

Voyager1 commented on pull request xbmc/xbmc#7190
@Voyager1

haven't checked in great detail, but it doesn't seem right. What problem are we trying to solve? If the MicroDVD subtitles need to be read, is the …

Voyager1 commented on pull request xbmc/xbmc#7190
@Voyager1

makes complete sense to me as well... +1

Voyager1 commented on commit ace20022/xbmc@8e1f62cc1b
@Voyager1

you're welcome :-)

Voyager1 commented on commit ace20022/xbmc@8e1f62cc1b
@Voyager1

accessing cdio_loglevel_default throws an "access violation" under Windows... This change breaks Kodi on Windows. UPDATE: I actually have an optica…

Voyager1 commented on commit ace20022/xbmc@1c089690be
@Voyager1

indeed, and it should really be the rare exception, because usually Multi-stream VobSubs have those parameters correctly set anyway.

Voyager1 commented on commit ace20022/xbmc@1c089690be
@Voyager1

+1 - looks fine to me. I had stumbled upon this issue of only updating the members of subtitle stream index 0 before. Glad you introduced the loop …

Voyager1 commented on commit ace20022/xbmc@1c089690be
@Voyager1

this could stay outside of the loop, couldn't it?

Voyager1 commented on pull request xbmc/xbmc#6648
@Voyager1

For completeness sake: this is more than just about warnings - caused major breakage due to unconditional code execution.

Voyager1 commented on pull request xbmc/xbmc#6415
@Voyager1

I arrived at the same conclusion just now - thanks that was it indeed :-)

Voyager1 commented on pull request xbmc/xbmc#6415
@Voyager1

sorry - it's not ffmpeg, it's not the chapter stuff - I found the cause and am working on a fix. Last good build was the one right before the Tuxbo…

Voyager1 commented on pull request xbmc/xbmc#6415
@Voyager1

@ace20022 - disregard my comment. It's ffmpeg 2.6 which I was also testing in parallel. @FernetMenta I would advise against merging ffmpeg 2.6 unti…

Voyager1 commented on pull request xbmc/xbmc#6415
@Voyager1

@ace20022 this seems to break DVD menus completely: either stills are 'black', overlays are not shown. Any idea?

Voyager1 commented on pull request xbmc/xbmc#6610
@Voyager1

are you sure that this map gets properly cleared between playback of different DVDs?

Voyager1 commented on pull request xbmc/xbmc#6513
@Voyager1

thanks, much easier to read :-)

Voyager1 commented on pull request xbmc/xbmc#6513
@Voyager1

just confirming this is fixed.

Voyager1 commented on pull request xbmc/xbmc#6513
@Voyager1

Ah - I didn't notice the 1000 msec 'cacheing delay' in CApplicationPlayer::GetAudioStream() - that was obviously the culprit. First test indicates …

Voyager1 commented on pull request xbmc/xbmc#6479
@Voyager1

there's some kind of cacheing going on in g_application.m_pPlayer->GetAudioStreamInfo() as you noticed, but not for the codec name apparently (stil…

Voyager1 commented on pull request xbmc/xbmc#6479
@Voyager1

hi @FernetMenta - I noticed this PR that you had open for a day but then closed without further comments. I actually just have had an issue with a …

Voyager1 commented on pull request xbmc/xbmc#6433
@Voyager1

@MartijnKaijser how do we proceed? I could merge this, but it would only positively affect the jenkins build if you change the "noclean" to "clean".

Voyager1 commented on pull request xbmc/xbmc#6433
@Voyager1

ha! that's good to know. but since "noclean" is used, this would not kick in anyway. We could do either one of two things, a) change Jenkins to use…

Voyager1 commented on pull request xbmc/xbmc#6433
@Voyager1

what I meant is that Jenkins uses xbmc\tools\buildsteps\win32 batch-files instead of BuildSetup.bat. So this change cannot be verified through Jenk…

Voyager1 commented on pull request xbmc/xbmc#6433
@Voyager1

Note: no need to build with Jenkins here, since this is not used within the Jenkins build.

Voyager1 opened pull request xbmc/xbmc#6433
@Voyager1
[Win32] Fix occasional build errors related to unclean binary addons build
1 commit with 3 additions and 0 deletions