Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releases back into timeline #736

Merged
merged 11 commits into from
Apr 24, 2020
Merged

Add releases back into timeline #736

merged 11 commits into from
Apr 24, 2020

Conversation

Xetnus
Copy link
Collaborator

@Xetnus Xetnus commented Mar 20, 2020

Fixes #419 by:

  1. Creating a link between the Release and Project models
  2. Adding an API endpoint (/api/projects/1/releases) to get the releases for a particular project
  3. Using that endpoint to load in the releases and events for a vulnerability in parallel
  4. Merging releases and normal events into one global array, but still distinguishing between releases and normal events when necessary, like when clicking on the chics/ticks
  5. Moving the zoom and reset buttons down below the timeline
  6. Adding unit tests for the release model

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-419-epgahll March 20, 2020 00:58 Inactive
@andymeneely andymeneely had a problem deploying to vulnerabilit-issue-419-epgahll March 20, 2020 00:59 Failure
@coveralls
Copy link

coveralls commented Mar 20, 2020

Pull Request Test Coverage Report for Build 1358

  • 31 of 36 (86.11%) changed or added relevant lines in 6 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 88.59%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/projects_controller.rb 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
app/controllers/filepaths_controller.rb 3 37.93%
lib/event_generators/weekly_report_events.rb 20 26.44%
Totals Coverage Status
Change from base Build 959: -0.3%
Covered Lines: 1382
Relevant Lines: 1560

💛 - Coveralls

@Xetnus Xetnus added the dont merge yet! Don't merge these pull requests yet label Apr 2, 2020
@Xetnus
Copy link
Collaborator Author

Xetnus commented Apr 2, 2020

Based on our discussion last Thursday, I'm going to create a new section of buttons below and to the right of the horizontal timeline that would hold the Zoom Level button and Reset button. This means that those buttons would be moved down from where they are now.

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-419-epgahll April 9, 2020 03:53 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-419-epgahll April 10, 2020 01:31 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-419-epgahll April 16, 2020 19:09 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-419-epgahll April 23, 2020 03:03 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-419-epgahll April 23, 2020 17:57 Inactive
@Xetnus Xetnus removed the dont merge yet! Don't merge these pull requests yet label Apr 23, 2020
@andymeneely andymeneely merged commit 1b93a4f into master Apr 24, 2020
@andymeneely andymeneely deleted the issue-419 branch April 24, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release events to go back into vulnerability timeline show
3 participants