Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:: Generate correct ISO 8601 timestamps in UTC for alerting #187

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

frikilax
Copy link
Member

@frikilax frikilax commented Jun 5, 2020

✨ FIX:: Generate correct ISO 8601 timestamps in UTC for alerting

‼️ Once all the checklist is done you have to:

  • stash merge this pull request
  • delete the corresponding branch
  • close the associated issue

📃 Type of change

Bug fix: non-breaking change which fixes an issue.
Breaking change: fix or feature that would cause existing functionality to not work as expected.

💡 Related Issue(s)

✒️ Description

Changed GetTime's toolkit function to return valid RFC3339 timestamps, used for alerts generation.
[BREAKING CHANGE] Those timestamps are now always generated as UTC.

🎯 Test Environments

HBSD (12.1)

  • g++ (9.3.0)
  • CMake (3.17.2)

Ubuntu (18.04)

  • g++ (or clang++) (7.5.0)
  • CMake (3.10.2)
  • Valgrind (3.13.0)

✔️ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • (If other changes) I have made corresponding changes to the documentation
  • New and existing tests pass locally with my changes

  • 🙋 I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code

@frikilax frikilax added bug Something isn't working easy labels Jun 5, 2020
@frikilax frikilax added this to the Version 1.3 milestone Jun 5, 2020
@frikilax frikilax self-assigned this Jun 5, 2020
@frikilax frikilax merged commit aa178d1 into dev Jun 15, 2020
@frikilax frikilax deleted the fix_alert_timestamp branch June 15, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants