Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cache Policy with CDN CloudFront and S3 #47

Closed
wants to merge 1 commit into from

Conversation

@seang96
Copy link

seang96 commented Sep 18, 2019

This fixes issue #27 by setting CdnEngine_CloudFront to be a subclass of CdnEngine_S3 which in effect allows cache_config to be set for the entire object and reduces the code needed to be covered in CdnEngine_CloudFront.

@bwmarkle

This comment has been minimized.

Copy link
Contributor

bwmarkle commented Sep 20, 2019

Hi @seang96 thanks for the pull request. I'm ecstatic to see users like yourself beginning to submit them to the public repo! I'm touching base with the developers on this one, and hopefully soon we'll have some feedback for you.

Thanks!
- Brad

@maxicus

This comment has been minimized.

Copy link
Contributor

maxicus commented Nov 6, 2019

Fixed differently, anyway thank you for your detailed report about problem.

@maxicus maxicus closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.