Skip to content

Conversation

@Da-Be-Ru
Copy link
Member

@Da-Be-Ru Da-Be-Ru commented Nov 14, 2025

While trying to test the cellparents speedup for lazy_interpolate #54 on a ringsector mesh, I ran into the following odd behaviour I haven't examined in detail yet: when interpolating a function into an H1Pk element on a zero times uniformly refined ringsector, we get some out of bounds error in the evaluate! call.

This goes away when the ringsector is actually refined once (though it does kill any lazy_interpolate! call, cellparents use or no...).

HINT: ExtendableGrids needs to be checked out to #100 for this to run

@chmerdon
Copy link
Member

chmerdon commented Nov 14, 2025

At first glance this looks like that maybe the mesh is corrupted and has nodes that are not used in any cell. I'll try to figure it out.

@chmerdon
Copy link
Member

Yes, the last six nodes are duplicates of the first six nodes. If you do
xgrid1[Coordinates] = xgrid1[Coordinates][:,1:54]
everything works

So this is a bug in the ringsector function of ExtendableGrids

@chmerdon
Copy link
Member

Well at least the normal interpolations work then, but the lazy_interpolations hang up at some point.

This is weird, because I checked that the initcell chosen by the cellparents is a cell that contains the vertex coordinates, so the cell finder should stop after one iteration.

When I reduce the eps to 1e-6, it seems to work again. So, I think we need to investigate thoroughly what happens in the cellfinder.

@Da-Be-Ru
Copy link
Member Author

Yes, the last six nodes are duplicates of the first six nodes. If you do xgrid1[Coordinates] = xgrid1[Coordinates][:,1:54] everything works

So this is a bug in the ringsector function of ExtendableGrids
[...]
When I reduce the eps to 1e-6, it seems to work again. So, I think we need to investigate thoroughly what happens in the cellfinder.

Both of these are now solved by the related PR in ExtendableGrids.jl as suggested by you.

Properly escalated, so closing this PR.

@Da-Be-Ru Da-Be-Ru closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants