-
Notifications
You must be signed in to change notification settings - Fork 6
Bug: ringsector breaks interpolation call #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
At first glance this looks like that maybe the mesh is corrupted and has nodes that are not used in any cell. I'll try to figure it out. |
|
Yes, the last six nodes are duplicates of the first six nodes. If you do So this is a bug in the ringsector function of ExtendableGrids |
|
Well at least the normal interpolations work then, but the lazy_interpolations hang up at some point. This is weird, because I checked that the initcell chosen by the cellparents is a cell that contains the vertex coordinates, so the cell finder should stop after one iteration. When I reduce the eps to 1e-6, it seems to work again. So, I think we need to investigate thoroughly what happens in the cellfinder. |
Both of these are now solved by the related PR in Properly escalated, so closing this PR. |
While trying to test the
cellparentsspeedup forlazy_interpolate#54 on aringsectormesh, I ran into the following odd behaviour I haven't examined in detail yet: when interpolating a function into anH1Pkelement on a zero times uniformly refinedringsector, we get some out of bounds error in theevaluate!call.This goes away when the
ringsectoris actually refined once (though it does kill anylazy_interpolate!call,cellparentsuse or no...).HINT:
ExtendableGridsneeds to be checked out to#100for this to run