Changes in sorting on Julia master

[dkarrasch]

I am testing this package locally on the Julia branch related to JuliaLang/julia#47107. I am getting the following sorting related errors:

Preconditioners: Error During Test at /Users/karrasch/.julia/packages/ExtendableSparse/6p0oQ/test/test_preconditioners.jl:39
  Test threw exception
  Expression: all(isapprox.(test_precon(ILUTPreconditioner, 20, 20, 20), (true, 1.2719511868322086e-5), rtol = 0.001))
  UndefVarError: `QuickSortAlg` not defined
  Stacktrace:
    [1] getproperty
      @ ./Base.jl:31 [inlined]
    [2] append_col!(A::SparseMatrixCSC{Float64, Int64}, y::IncompleteLU.SparseVectorAccumulator{Float64, Int64}, j::Int64, drop::Float64, scale::Float64)
      @ IncompleteLU ~/.julia/packages/IncompleteLU/UBpTh/src/sparse_vector_accumulator.jl:118
    [3] append_col!
      @ ~/.julia/packages/IncompleteLU/UBpTh/src/sparse_vector_accumulator.jl:105 [inlined]
    [4] ilu(A::SparseMatrixCSC{Float64, Int64}; τ::Float64)
      @ IncompleteLU ~/.julia/packages/IncompleteLU/UBpTh/src/crout_ilu.jl:96
    [5] ilu
      @ ~/.julia/packages/IncompleteLU/UBpTh/src/crout_ilu.jl:9 [inlined]
    [6] update!
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/src/ilut.jl:31 [inlined]
    [7] factorize!
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/src/factorizations.jl:62 [inlined]
    [8] #ILUTPreconditioner#124
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/src/factorizations.jl:120 [inlined]
    [9] ILUTPreconditioner(A::ExtendableSparseMatrix{Float64, Int64})
      @ ExtendableSparse ~/.julia/packages/ExtendableSparse/6p0oQ/src/factorizations.jl:120
   [10] test_precon(Precon::Type{ILUTPreconditioner}, k::Int64, l::Int64, m::Int64; maxiter::Int64)
      @ Main.test_preconditioners ~/.julia/packages/ExtendableSparse/6p0oQ/test/test_preconditioners.jl:13
   [11] test_precon(Precon::Type, k::Int64, l::Int64, m::Int64)
      @ Main.test_preconditioners ~/.julia/packages/ExtendableSparse/6p0oQ/test/test_preconditioners.jl:9
   [12] top-level scope
      @ ~/Documents/julia/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:477
   [13] include(fname::String)
      @ Base.MainInclude ./client.jl:478
   [14] macro expansion
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/test/runtests.jl:51 [inlined]
   [15] macro expansion
      @ ~/Documents/julia/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:1496 [inlined]
   [16] top-level scope
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/test/runtests.jl:51
Preconditioners: Error During Test at /Users/karrasch/.julia/packages/ExtendableSparse/6p0oQ/test/test_preconditioners.jl:45
  Test threw exception
  Expression: all(isapprox.(test_precon2(ILUTPreconditioner(), 20, 20, 20), (true, 1.2719511868322086e-5), rtol = 0.001))
  UndefVarError: `QuickSortAlg` not defined
  Stacktrace:
    [1] getproperty
      @ ./Base.jl:31 [inlined]
    [2] append_col!(A::SparseMatrixCSC{Float64, Int64}, y::IncompleteLU.SparseVectorAccumulator{Float64, Int64}, j::Int64, drop::Float64, scale::Float64)
      @ IncompleteLU ~/.julia/packages/IncompleteLU/UBpTh/src/sparse_vector_accumulator.jl:118
    [3] append_col!
      @ ~/.julia/packages/IncompleteLU/UBpTh/src/sparse_vector_accumulator.jl:105 [inlined]
    [4] ilu(A::SparseMatrixCSC{Float64, Int64}; τ::Float64)
      @ IncompleteLU ~/.julia/packages/IncompleteLU/UBpTh/src/crout_ilu.jl:96
    [5] ilu
      @ ~/.julia/packages/IncompleteLU/UBpTh/src/crout_ilu.jl:9 [inlined]
    [6] update!
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/src/ilut.jl:31 [inlined]
    [7] factorize!(p::ILUTPreconditioner{Float64, Int64}, A::ExtendableSparseMatrix{Float64, Int64})
      @ ExtendableSparse ~/.julia/packages/ExtendableSparse/6p0oQ/src/factorizations.jl:62
    [8] test_precon2(precon::ILUTPreconditioner{Float64, Int64}, k::Int64, l::Int64, m::Int64; maxiter::Int64)
      @ Main.test_preconditioners ~/.julia/packages/ExtendableSparse/6p0oQ/test/test_preconditioners.jl:26
    [9] test_precon2(precon::ILUTPreconditioner{Float64, Int64}, k::Int64, l::Int64, m::Int64)
      @ Main.test_preconditioners ~/.julia/packages/ExtendableSparse/6p0oQ/test/test_preconditioners.jl:22
   [10] top-level scope
      @ ~/Documents/julia/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:477
   [11] include(fname::String)
      @ Base.MainInclude ./client.jl:478
   [12] macro expansion
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/test/runtests.jl:51 [inlined]
   [13] macro expansion
      @ ~/Documents/julia/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:1496 [inlined]
   [14] top-level scope
      @ ~/.julia/packages/ExtendableSparse/6p0oQ/test/runtests.jl:51
Test Summary:   | Pass  Error  Total   Time
Preconditioners |    8      2     10  26.2s

The changes must have been done after your last commit to your master branch, so roughly in the past three weeks.

[j-fu]

Thank you!

Ok it was [this commit] (JuliaLang/julia@35431bf)

which redefined QuickSort (in the public API) and removed QuickSortAlg() (which was not in the public API) .

This however concerns IncompleteLU.jl which is used in testing only and otherwise used via Requires. It used QuickSortAlg() which is now gone (formally non-breaking). I'll notify them.

(BTW waiting for JuliaLang/Pkg.jl#3229 regarding Requires...)

[j-fu]

Ok the PR was merged, and I bumped the compat in 'test/Project.toml'. With 0.9.2 regsistered it should work IMHO.