Skip to content

Conversation

@bmmogensen
Copy link
Contributor

Hi maintainers,

This PR allows for including ExtendableSparse.jl in Julia and sysimages built without GPL libraries. Most notably, this removes SuiteSparse, which is naturally a dependency for several of the operations of the module.

This does not fix the inherent problems with not having SuiteSparse, but just allows us to compile a sysimage, and provided that we do not use any of the features requiring SuiteSparse, it will work fine.

Best,
Bjorn

@j-fu
Copy link
Member

j-fu commented Aug 31, 2022

Ok thanks - I have no time to test this in sysimage building or in in the case without GPL libs, but implementation looks reasonable, so I merge.

For a replacemnent of Suitsparse I hint at Petr Krysl's Sparspak.jl. I plan to support this at least via require. Contemplating to make it the default LU factorization in then non-gpl case.

@j-fu j-fu merged commit e216523 into WIAS-PDELib:master Aug 31, 2022
@j-fu
Copy link
Member

j-fu commented Aug 31, 2022

BTW Pardiso is not GPL so I will remove the conditional in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants