Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering aggregation keys #649

Closed
johnivdel opened this issue Dec 12, 2022 · 1 comment · Fixed by #1149
Closed

Allow filtering aggregation keys #649

johnivdel opened this issue Dec 12, 2022 · 1 comment · Fixed by #1149
Assignees
Labels
possible-future-enhancement Feature request with no current decision on adoption

Comments

@johnivdel
Copy link
Collaborator

Currently, the API only supports filtering on key_pieces, rather than keys themselves. This means that you cannot control what aggregation keys get recorded for a trigger based on cross-site data, but instead only source side data.

@csharrison csharrison added the possible-future-enhancement Feature request with no current decision on adoption label Jun 26, 2023
@agarant agarant self-assigned this Sep 11, 2023
@linnan-github
Copy link
Collaborator

We may consider allowing aggregatable_values field to specify a lists of values with filters, and similar to aggregatable_deduplication_keysfield, the first values in the list with matching filters will be used.

{
  "aggregatable_values": [
    {
      "values": {
        "a1": 1092,
        "a2": 1234,
      },
      "filters": ...,
      "not_filters": ...
    },
    {
      "values": {
        "a1": 1638,
        "a2": 4321,
      },
      "filters": ...,
      "not_filters": ...
    }
  ],
  ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-future-enhancement Feature request with no current decision on adoption
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants