Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

Update explainer and spec to support multiple destinations - #601

Merged
csharrison merged 6 commits into
mainfrom
destination
Nov 7, 2022
Merged

csharrison merged 6 commits into
mainfrom
destination

Conversation

@csharrison

@csharrison csharrison commented Nov 4, 2022 •

Copy link
Copy Markdown
Collaborator

Fixes #44 as far as I can tell. This PR attempts to be a fully backwards compatible change, so existing deployments will not have to update any code to accomodate.

Addresses #549, not calling it fixed until further verification.


Preview | Diff

Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
Comment thread index.bs Resolved
@csharrison
csharrison marked this pull request as ready for review November 4, 2022 15:47
csharrison and others added 2 commits November 4, 2022 11:05
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
@csharrison
csharrison requested a review from apasel422 November 4, 2022 21:45
@apasel422

Copy link
Copy Markdown
Contributor

@csharrison Would it be possible for you to update the header validator in this PR as well? If not, I can do it in a followup.

@csharrison

Copy link
Copy Markdown
Collaborator Author

@csharrison Would it be possible for you to update the header validator in this PR as well? If not, I can do it in a followup.

Done

@johnivdel johnivdel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

Comment thread EVENT.md Resolved
Comment thread index.bs Resolved
@csharrison
csharrison requested a review from johnivdel November 7, 2022 18:22

@johnivdel johnivdel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversions coming from a different domain than landing page

3 participants