Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chooseFileSystemEntries naming and behavior is misleading #146

Open
tomayac opened this issue Jan 22, 2020 · 0 comments
Open

chooseFileSystemEntries naming and behavior is misleading #146

tomayac opened this issue Jan 22, 2020 · 0 comments

Comments

@tomayac
Copy link

@tomayac tomayac commented Jan 22, 2020

The method name chooseFileSystemEntries suggests it's for choosing files (plural), which then in turn implies the multiple field from the ChooseFileSystemEntriesOptions is somewhat superfluous.

Do we maybe need a new method chooseFileSystemEntry (singular) and consequently remove the multiple field from the ChooseFileSystemEntriesOptions entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.