Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getOriginPrivateDirectory is not a name that's friendly to partitioning #211

Closed
annevk opened this issue Aug 5, 2020 · 3 comments · Fixed by #217
Closed

getOriginPrivateDirectory is not a name that's friendly to partitioning #211

annevk opened this issue Aug 5, 2020 · 3 comments · Fixed by #217
Milestone

Comments

@annevk
Copy link

annevk commented Aug 5, 2020

It assumes that the storage key will forever be an origin, which is less and less the case.

@inexorabletash
Copy link
Collaborator

Good point. Any name suggestions?

@annevk
Copy link
Author

annevk commented Aug 5, 2020

getStorageDirectory() or some such? Or navigator.storage.getDirectory()?

@mkruisselbrink mkruisselbrink added this to the V1 milestone Aug 5, 2020
@mkruisselbrink
Copy link
Contributor

I'm leaning towards either navigator.storage.getDirectory(), or moving the entire API surface to a FileSystem namespace (as suggested in #210), and thus ending up with FileSystem.getPrivateDirectory().
(i.e. either 6192c45 or 345af0a)

navigator.storage seems a bit weird, since none of the other storage APIs are exposed via navigator, but that's probably okay. After all what existing APIs do via a singleton on the global seems to be explicitly against TAG guidance for new APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants