Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reserved.top_navigation_start/commit automatic beacon types #885

Merged
merged 4 commits into from Nov 10, 2023

Conversation

blu25
Copy link
Contributor

@blu25 blu25 commented Oct 25, 2023

The "reserved.top_navigation" automatic beacon type will be deprecated in favor of "reserved.top_navigation_start" (which will send at the start of a navigation) and "reserved.top_navigation_commit" (which will send when the navigation commits).

Note: The "reserved.top_navigation" type will continue to be supported for the time being, but will be removed at some point in the future.

Copy link
Contributor

@shivanigithub shivanigithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % adding clarification of the meanings of start and commit.

Fenced_Frames_Ads_Reporting.md Show resolved Hide resolved
Copy link
Contributor

@shivanigithub shivanigithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with some rephrasing to include linking to the navigation spec

Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
@JensenPaul JensenPaul merged commit 734b7f9 into WICG:main Nov 10, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 10, 2023
SHA: 734b7f9
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to qingxinwu/turtledove that referenced this pull request Nov 10, 2023
…#885)

SHA: 734b7f9
Reason: push, by qingxinwu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants