From 787c9ed735c890e8f3fba09a9d36cb52bf3984f5 Mon Sep 17 00:00:00 2001 From: Jonathan Lim-Breitbart Date: Tue, 13 May 2025 09:11:53 -0700 Subject: [PATCH 1/5] feat(Unit Library): Add info link to Type filter --- .../library-filters.component.html | 6 +++++- .../library-filters.component.scss | 4 ++++ .../library-filters.component.ts | 17 +++++++++++++++++ 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/src/app/modules/library/library-filters/library-filters.component.html b/src/app/modules/library/library-filters/library-filters.component.html index 79e797d46d4..52a9022624b 100644 --- a/src/app/modules/library/library-filters/library-filters.component.html +++ b/src/app/modules/library/library-filters/library-filters.component.html @@ -35,11 +35,12 @@

Filters

> @if (unitTypeOptions.length > 0) {
Filters [viewValueProp]="'name'" [multiple]="true" /> + + info +
} @if (disciplineOptions.length > 0) { diff --git a/src/app/modules/library/library-filters/library-filters.component.scss b/src/app/modules/library/library-filters/library-filters.component.scss index 9099f69accd..9f6a70a958e 100644 --- a/src/app/modules/library/library-filters/library-filters.component.scss +++ b/src/app/modules/library/library-filters/library-filters.component.scss @@ -29,3 +29,7 @@ h3 { .library-filter { margin: 0; } + +a { + cursor: pointer; +} diff --git a/src/app/modules/library/library-filters/library-filters.component.ts b/src/app/modules/library/library-filters/library-filters.component.ts index 5599260ca3e..808b7e5cb9b 100644 --- a/src/app/modules/library/library-filters/library-filters.component.ts +++ b/src/app/modules/library/library-filters/library-filters.component.ts @@ -14,6 +14,8 @@ import { SelectMenuComponent } from '../../shared/select-menu/select-menu.compon import { StandardsSelectMenuComponent } from '../../shared/standards-select-menu/standards-select-menu.component'; import { Feature } from '../Feature'; import { Grade, GradeLevel } from '../GradeLevel'; +import { MatDialog } from '@angular/material/dialog'; +import { DialogWithCloseComponent } from '../../../../assets/wise5/directives/dialog-with-close/dialog-with-close.component'; @Component({ imports: [ @@ -48,6 +50,7 @@ export class LibraryFiltersComponent { ]; constructor( + private dialog: MatDialog, protected filterValues: ProjectFilterValues, private libraryService: LibraryService, private utilService: UtilService @@ -177,4 +180,18 @@ export class LibraryFiltersComponent { this.filterValues.clear(); this.emitFilterValues(); } + + protected showTypeInfo(): void { + const message = $localize`"Type" indicates the platform on which a unit runs. "WISE Platform" units are created + using the WISE authoring tool. Students use WISE accounts to complete lessons and teachers can review and grade + work on the WISE platform. "Other" units are created using different platforms. Resources for these units + are linked in the unit details.`; + this.dialog.open(DialogWithCloseComponent, { + data: { + content: message, + title: $localize`Unit Type` + }, + panelClass: 'dialog-sm' + }); + } } From 3cb9bc131e76cfaea9611a7137d4cda1fc4db4d2 Mon Sep 17 00:00:00 2001 From: Jonathan Lim-Breitbart Date: Tue, 13 May 2025 09:41:22 -0700 Subject: [PATCH 2/5] feat(Unit Details): Change text of Preview button for non-WISE units Add information about non-WISE units to top of unit details. --- .../library-project-details.component.html | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/app/modules/library/library-project-details/library-project-details.component.html b/src/app/modules/library/library-project-details/library-project-details.component.html index 445bb0c5157..e1d44a960eb 100644 --- a/src/app/modules/library/library-project-details/library-project-details.component.html +++ b/src/app/modules/library/library-project-details/library-project-details.component.html @@ -68,6 +68,12 @@ >

} + @if (project.metadata.unitType !== 'Platform') { +

+ *Note: This unit was created outside of the WISE platform. Teaching resources are linked + below. +

+ } @if (project.metadata.resources?.length > 0) {

Resources: @@ -210,7 +216,12 @@ } @if (canPreview) { } From b24439a4f0990048cf80d0936117b56179c5b5a9 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Tue, 13 May 2025 16:53:27 +0000 Subject: [PATCH 3/5] Updated messages --- src/messages.xlf | 95 +++++++++++++++++++++++++++++++++--------------- 1 file changed, 65 insertions(+), 30 deletions(-) diff --git a/src/messages.xlf b/src/messages.xlf index 192486b8aa9..858dd525df7 100644 --- a/src/messages.xlf +++ b/src/messages.xlf @@ -283,7 +283,7 @@ src/app/modules/library/library-project-details/library-project-details.component.html - 198,202 + 204,208 src/app/modules/library/public-unit-type-selector/community-library-details.html @@ -1059,7 +1059,7 @@ Click "Cancel" to keep the invalid JSON open so you can fix it. src/app/modules/library/library-filters/library-filters.component.html - 46,47 + 47,48 src/assets/wise5/authoringTool/milestones-authoring/milestones-authoring.component.html @@ -5493,7 +5493,7 @@ Click "Cancel" to keep the invalid JSON open so you can fix it. src/app/modules/library/library-filters/library-filters.component.html - 117,119 + 121,123 src/app/modules/mobile-menu/mobile-menu.component.html @@ -5795,46 +5795,53 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.29,34 + + Type filter explanation + + src/app/modules/library/library-filters/library-filters.component.html + 54,58 + + Discipline src/app/modules/library/library-filters/library-filters.component.html - 63,65 + 67,69 Grade Level src/app/modules/library/library-filters/library-filters.component.html - 81,83 + 85,87 Standards Addressed src/app/modules/library/library-filters/library-filters.component.html - 100,102 + 104,106 WISE Platform src/app/modules/library/library-filters/library-filters.component.ts - 46 + 48 Other Platform src/app/modules/library/library-filters/library-filters.component.ts - 47 + 49 NGSS src/app/modules/library/library-filters/library-filters.component.ts - 111 + 114 src/app/modules/library/library-project-details/library-project-details.component.ts @@ -5845,7 +5852,7 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.Common Core src/app/modules/library/library-filters/library-filters.component.ts - 112 + 115 src/app/modules/library/library-project-details/library-project-details.component.ts @@ -5856,13 +5863,34 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.Learning For Justice src/app/modules/library/library-filters/library-filters.component.ts - 113 + 116 src/app/modules/library/library-project-details/library-project-details.component.ts 51 + + "Type" indicates the platform on which a unit runs. "WISE Platform" units are created + using the WISE authoring tool. Students use WISE accounts to complete lessons and teachers can review and grade + work on the WISE platform. "Other" units are created using different platforms. Resources for these units + are linked in the unit details. + + src/app/modules/library/library-filters/library-filters.component.ts + 185,188 + + + + Unit Type + + src/app/modules/library/library-filters/library-filters.component.ts + 192 + + + src/assets/wise5/authoringTool/edit-unit-type/edit-unit-type.component.html + 1,2 + + : @@ -5913,81 +5941,88 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.37,39 + + *Note: This unit was created outside of the WISE platform. Teaching resources are linked below. + + src/app/modules/library/library-project-details/library-project-details.component.html + 73,77 + + Resources: src/app/modules/library/library-project-details/library-project-details.component.html - 73,75 + 79,81 Discipline: src/app/modules/library/library-project-details/library-project-details.component.html - 86,88 + 92,94 Features: src/app/modules/library/library-project-details/library-project-details.component.html - 98,99 + 104,105 Standards Addressed: src/app/modules/library/library-project-details/library-project-details.component.html - 111,113 + 117,119 This unit is a copy of (used under CC BY-SA). src/app/modules/library/library-project-details/library-project-details.component.html - 154,156 + 160,162 This unit is a copy of by (used under CC BY-SA). src/app/modules/library/library-project-details/library-project-details.component.html - 160,163 + 166,169 This unit is licensed under CC BY-SA. src/app/modules/library/library-project-details/library-project-details.component.html - 171,173 + 177,179 This unit is licensed under CC BY-SA by . src/app/modules/library/library-project-details/library-project-details.component.html - 176,178 + 182,184 View License src/app/modules/library/library-project-details/library-project-details.component.html - 183,187 + 189,193 More src/app/modules/library/library-project-details/library-project-details.component.html - 191,197 + 197,203 Use with Class src/app/modules/library/library-project-details/library-project-details.component.html - 207,212 + 213,218 src/app/teacher/create-run-dialog/create-run-dialog.component.html @@ -5998,7 +6033,7 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.Preview src/app/modules/library/library-project-details/library-project-details.component.html - 213,217 + 221,223 src/app/teacher/run-menu/run-menu.component.html @@ -6029,6 +6064,13 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.71,74 + + Unit Resources + + src/app/modules/library/library-project-details/library-project-details.component.html + 223,228 + + License pertains to original content created by the author(s). Authors are responsible for the usage and attribution of any third-party content linked to or included in this work. @@ -11245,13 +11287,6 @@ The branches will be removed but the steps will remain in the unit. 99 - - Unit Type - - src/assets/wise5/authoringTool/edit-unit-type/edit-unit-type.component.html - 1,2 - - WISE Platform (Uses features on this platform to collect student data) From 615a27a9d535515c560b2b486a2f8de58ed9eaa4 Mon Sep 17 00:00:00 2001 From: Jonathan Lim-Breitbart Date: Tue, 13 May 2025 11:23:47 -0700 Subject: [PATCH 4/5] Make notice about Other unit types more visible --- .../library-project-details.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/modules/library/library-project-details/library-project-details.component.html b/src/app/modules/library/library-project-details/library-project-details.component.html index e1d44a960eb..fc19f42cb8b 100644 --- a/src/app/modules/library/library-project-details/library-project-details.component.html +++ b/src/app/modules/library/library-project-details/library-project-details.component.html @@ -69,8 +69,8 @@

} @if (project.metadata.unitType !== 'Platform') { -

- *Note: This unit was created outside of the WISE platform. Teaching resources are linked +

+ Note: This unit was created outside of the WISE platform. Teaching resources are linked below.

} From 5034a488784ee3bd86d4a58dbfd84421eeb2888a Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Tue, 13 May 2025 18:28:51 +0000 Subject: [PATCH 5/5] Updated messages --- src/messages.xlf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/messages.xlf b/src/messages.xlf index 858dd525df7..f7831fea888 100644 --- a/src/messages.xlf +++ b/src/messages.xlf @@ -5941,8 +5941,8 @@ Click "Cancel" to keep the invalid JSON open so you can fix it.37,39 - - *Note: This unit was created outside of the WISE platform. Teaching resources are linked below. + + Note: This unit was created outside of the WISE platform. Teaching resources are linked below. src/app/modules/library/library-project-details/library-project-details.component.html 73,77