Skip to content

feat(TeacherTools): Show workgroups in tooltip for Sort summary#2319

Merged
breity merged 3 commits into
developfrom
match-summary-show-workgroups
Jun 8, 2026
Merged

feat(TeacherTools): Show workgroups in tooltip for Sort summary#2319
breity merged 3 commits into
developfrom
match-summary-show-workgroups

Conversation

@breity

@breity breity commented Jun 5, 2026

Copy link
Copy Markdown
Member

Changes

  • Show a list of workgroup names in a tooltip when hovering over each item or bucket in Sort (Match) summary view in the teacher tools.

Test

  • Go to Grade by Step in the Teacher Tools for a run with a step that includes a Sort activity. Select the step and then the question summary for the Sort activity.
  • In Bucket view, make sure that when you mouse over (or Tab to using keyboard) the person icon + count for each item that a tooltip appears showing the names for the workgroups that moved that item into the bucket.
  • In Item view, make sure that when you mouse over (or Tab to using keyboard) the person icon + count for each bucket that a tooltip appears showing the names for the workgroups that moved the item into that bucket.

@breity breity requested a review from hirokiterashima June 5, 2026 17:02
@breity breity self-assigned this Jun 5, 2026
@breity breity added the enhancement New feature of any size or improvement (UI, performance, security) label Jun 5, 2026
@qltysh

qltysh Bot commented Jun 5, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
New Coverage rating: A
.../teacher-summary-display/summary-data/MatchSummaryDataPoint.ts100.0%
New Coverage rating: A
...tives/teacher-summary-display/summary-data/MatchSummaryData.ts100.0%
New Coverage rating: A
...splay/match-summary-display/match-summary-display.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tooltip text works great for both owner and shared owner, but I'm a bit concerned about the hit to the performance this will cause.

The new getWorkgroupNames() function gets called many times. You can see this by adding console.log() in the function and just moving your mouse over the screen. It does the same calculations and returns the same result.

This could cause an issue with a class with many students and many buckets, especially on slower machines. Can we cache the result somewhere- maybe in MatchSummaryDisplayComponent or MatchSummaryDataPoint?

@breity

breity commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

@hirokiterashima Ah yes, I agree that could hinder performance. I refactored to cache the workgroup names in the MatchSummaryDisplayComponent.

@breity breity requested a review from hirokiterashima June 6, 2026 05:54

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good. 👍

@breity breity merged commit 12cbd7b into develop Jun 8, 2026
4 checks passed
@breity breity deleted the match-summary-show-workgroups branch June 8, 2026 17:50
@hirokiterashima

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.233.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants