From 3f33a4815a0267aef7fd776e2386130c7f949f34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ramirez=20Vargas=2C=20Jos=C3=A9=20Pablo?=
 <webJose@gmail.com>
Date: Tue, 18 Feb 2025 19:13:24 -0600
Subject: [PATCH 1/2] fix: Remove trailing slash on all path-joining operations

Fixes Route doesn't match if the only difference is the ending / #4

The `joinPaths` function now removes trailing slashes away when the result of joining forms a path with at least one segment.

The calculation for the test path removes any trailing slash as per the same rules above.
---
 src/lib/core/RouterEngine.svelte.ts | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/lib/core/RouterEngine.svelte.ts b/src/lib/core/RouterEngine.svelte.ts
index caac142..3b1b57b 100644
--- a/src/lib/core/RouterEngine.svelte.ts
+++ b/src/lib/core/RouterEngine.svelte.ts
@@ -47,12 +47,15 @@ function isRouterEngine(obj: unknown): obj is RouterEngine {
  */
 export function joinPaths(...paths: string[]) {
     const hasLeadingSlash = paths[0].startsWith('/');
-    const hasTrailingSlash = paths[paths.length - 1].endsWith('/');
     const result = paths.reduce((acc, path, index) => {
         const trimmedPath = (path ?? '').replace(/^\/|\/$/g, '');
         return acc + (index > 0 && !acc.endsWith('/') && trimmedPath.length > 0 ? '/' : '') + trimmedPath;
     }, hasLeadingSlash ? '/' : '');
-    return result + (hasTrailingSlash && result !== '/' ? '/' : '');
+    return noTrailingSlash(result);
+}
+
+function noTrailingSlash(path: string) {
+    return path !== '/' && path.endsWith('/') ? path.slice(0, -1) : path;
 }
 
 function routeInfoIsRegexInfo(info: unknown): info is RegexRouteInfo {
@@ -132,7 +135,7 @@ export class RouterEngine {
         return this.#routePatterns;
     }
 
-    #testPath = $derived.by(() => this.#hashId ? (location.hashPaths[this.#hashId] || '/') :this.url.pathname);
+    #testPath = $derived.by(() => noTrailingSlash(this.#hashId ? (location.hashPaths[this.#hashId] || '/') : this.url.pathname));
 
     #routeStatusData = $derived.by(() => {
         const routeStatus = {} as Record<string, RouteStatus>;

From f7ff1a12264c809cbad25bdaddf2fa2f8137467e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ramirez=20Vargas=2C=20Jos=C3=A9=20Pablo?=
 <webJose@gmail.com>
Date: Tue, 18 Feb 2025 19:16:11 -0600
Subject: [PATCH 2/2] tests:  Update RouterEngine's unit tests

---
 src/lib/core/RouterEngine.svelte.test.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/core/RouterEngine.svelte.test.ts b/src/lib/core/RouterEngine.svelte.test.ts
index d6252b2..3b9e15f 100644
--- a/src/lib/core/RouterEngine.svelte.test.ts
+++ b/src/lib/core/RouterEngine.svelte.test.ts
@@ -94,7 +94,7 @@ describe("RouterEngine", () => {
             // Assert.
             expect(basePath).toBe('/parent/child');
         });
-        test("Should preserve the trailing slash.", () => {
+        test("Should remove the trailing slash.", () => {
             // Arrange.
             const router = new RouterEngine();
             router.basePath = '/abc/';
@@ -103,7 +103,7 @@ describe("RouterEngine", () => {
             const basePath = router.basePath;
 
             // Assert.
-            expect(basePath).toBe('/abc/');
+            expect(basePath).toBe('/abc');
         });
     });
     describe('url', () => {