DateTime::createFromFormat() bug when editing posts #85

Closed
royboy789 opened this Issue Feb 21, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@royboy789

Sorry been a while since I've had motivation to come back to working on my project, and help expand anywhere I can with this awesome plugin.

I recently did a full update of my code including merging all new aspects of your plugin with my outdated one. However I'm noticing a new error come up. Even though I pull from /posts and then edit using the same pulled object (editing title or content only) I am getting these errors on return:

Warning:
DateTime::createFromFormat() expects parameter 3 to be DateTimeZone, integer given in .. / lib / class - wp - json - datetime.php on line 16

Error:
Call to a member function setTimezone() on a non-object in .. / lib / class - wp - json - server.php on line 718

any ideas?

@rachelbaker rachelbaker added the Bug label Feb 22, 2014

@rachelbaker rachelbaker added this to the 0.9 milestone Feb 22, 2014

@rachelbaker rachelbaker self-assigned this Feb 22, 2014

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Feb 22, 2014

Member

It looks like this was caused by SHA: d7e732f

Member

rachelbaker commented Feb 22, 2014

It looks like this was caused by SHA: d7e732f

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Feb 22, 2014

Member

@rmccue I have tested the code in my pull request, but can you double-check my work when you have a chance?

Member

rachelbaker commented Feb 22, 2014

@rmccue I have tested the code in my pull request, but can you double-check my work when you have a chance?

@rachelbaker rachelbaker assigned rmccue and unassigned rachelbaker Feb 22, 2014

rmccue added a commit that referenced this issue Mar 2, 2014

Merge pull request #87 from rachelbaker/issue-85
#85 - added timezone parameter to WP_JSON_DateTime::createFromFormat()

@rmccue rmccue closed this Mar 2, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Mar 2, 2014

Member

Should be fixed now. Thanks for the report, and patch! 🌵

Member

rmccue commented Mar 2, 2014

Should be fixed now. Thanks for the report, and patch! 🌵

@rmccue rmccue reopened this Mar 2, 2014

@rmccue rmccue closed this Mar 2, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this issue Aug 1, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this issue Aug 1, 2014

Merge pull request #87 from rachelbaker/issue-85
#85 - added timezone parameter to WP_JSON_DateTime::createFromFormat()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment