Skip to content
This repository has been archived by the owner. It is now read-only.

Show `show_in_rest` for exposing taxonomies, not `public` #1279

Merged
merged 1 commit into from May 21, 2015

Conversation

@joehoyle
Copy link
Contributor

commented May 21, 2015

Came out of #1216

@joehoyle

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2015

@WP-API/amigos #reviewmerge

@danielbachhuber danielbachhuber added this to the 2.0 Beta 2 milestone May 21, 2015
danielbachhuber pushed a commit that referenced this pull request May 21, 2015
Show `show_in_rest` for exposing taxonomies, not `public`
@danielbachhuber danielbachhuber merged commit 75dbebd into develop May 21, 2015
3 checks passed
3 checks passed
Scrutinizer 2 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on develop at 87.0%
Details
@danielbachhuber danielbachhuber deleted the taxonomies-show-in-rest branch May 21, 2015
@picklepete

This comment has been minimized.

Copy link

commented Feb 26, 2016

Hi @danielbachhuber - I just had a read through #1895 and I'm curious how this change, adding show_in_rest, will affect existing plugins which register custom taxonomies. Is your/WP-API's position going to be that these plugins should release an update to include show_in_rest?

I only ask because we @camayak are actively building a WP-API integration (we currently rely entirely on XML-RPC for publishing) and noticed a small-ish roadblock with your old plugin, Co-Authors Plus. At the moment with XML-RPC we can simply fetch the "author" taxonomy and its terms without any trouble, but using the latest WP-API release this line of code is rejecting the taxonomy altogether.

This is obviously a quick fix, which could maybe get included in this PR, but it's just a shame that WordPress site owners will need to upgrade all plugins which register_taxonomy before using the REST API's taxonomies endpoint.

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Feb 26, 2016

Is your/WP-API's position going to be that these plugins should release an update to include show_in_rest?

Yes, because they need to ensure their data is appropriately modeled before it's exposed in the REST API.

noticed a small-ish roadblock with your old plugin, Co-Authors Plus.

Co-Authors Plus is introducing its own endpoints, to ensure its data is appropriately modeled Automattic/Co-Authors-Plus#334

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.