data parameter is overwritten with JSON decoded data, even on failure #133

Merged
merged 1 commit into from Apr 14, 2014

Projects

None yet

2 participants

@rmccue
WordPress REST API Team member

Discovered by @rachelbaker.

If you pass data[title]=Hello%20World in the POST body, the data parameter internally gets overwritten with the result of json_decode. We should check json_last_error and skip if it's non-zero.

@rmccue rmccue added this to the 1.0 milestone Apr 14, 2014
@rmccue rmccue added the Bug label Apr 14, 2014
@rachelbaker rachelbaker merged commit e8bb59d into master Apr 14, 2014
@rmccue rmccue deleted the check-valid-json branch May 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment