Work with pretty permalinks disabled #138

Merged
merged 1 commit into from Apr 21, 2014

Conversation

Projects
None yet
2 participants
Owner

rmccue commented Apr 15, 2014

We should try and work with pretty permalinks disabled for compatibility's sake.

This supersedes #69.

@rmccue rmccue added this to the 1.0 milestone Apr 15, 2014

@rmccue rmccue added the Enhancement label Apr 15, 2014

@rmccue rmccue self-assigned this Apr 15, 2014

Owner

rmccue commented Apr 15, 2014

@rachelbaker #reviewmerge

@rmccue rmccue assigned rachelbaker and unassigned rmccue Apr 15, 2014

Owner

rachelbaker commented on faf4754 Apr 19, 2014

@rmccue During testing this patch still did not allow the JSON routes to respond without pretty permalinks enabled. This needs more debugging/testing.

Owner

rmccue commented Apr 20, 2014

@rmccue During testing this patch still did not allow the JSON routes to respond without pretty permalinks enabled. This needs more debugging/testing.

Hmm. I have pretty permalinks disabled, and /?json_route=/ works. What were you using to test?

rachelbaker added a commit that referenced this pull request Apr 21, 2014

Merge pull request #138 from WP-API/ugly-permalinks
Respond to requests without depending on pretty permalink settings.  Fixes #69.

@rachelbaker rachelbaker merged commit 8a71737 into master Apr 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Owner

rachelbaker commented Apr 21, 2014

@rmccue My fault. Tested and merged.

@rachelbaker rachelbaker deleted the ugly-permalinks branch May 1, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request #138 from WP-API/ugly-permalinks
Respond to requests without depending on pretty permalink settings.  Fixes #69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment