Skip to content
This repository has been archived by the owner. It is now read-only.

Add `role` to schema for users #1400

Merged
merged 1 commit into from Jul 23, 2015

Conversation

@joehoyle
Copy link
Contributor

commented Jul 12, 2015

This way we get to supply the clients with an enum of roles, also the field
for updating / creating a user is role. The maining question is whether to
remove support for multiple roles or not. Currently it's half of both.

Adding this PR to get the discussion moving!

This way we get to supply the clients with an `enum` of roles, also the
field for updating / creating a user is `role`. The maining question is
whether to remove support for multiple roles or not. Currently it's half
of both.

Adding this PR to get the discussion moving!
@joehoyle joehoyle self-assigned this Jul 12, 2015
@joehoyle joehoyle modified the milestones: 2.0, 2.0 Beta 4 Jul 12, 2015
@rmccue

This comment has been minimized.

Copy link
Member

commented Jul 23, 2015

The maining question is whether to remove support for multiple roles or not. Currently it's half of both.

#1280 for discussion about this issue.

Looks good to me. 👍

rmccue added a commit that referenced this pull request Jul 23, 2015
@rmccue rmccue merged commit 8ac5ca6 into develop Jul 23, 2015
4 checks passed
4 checks passed
Scrutinizer 3 updated code elements
Details
codecov/commit 100.00% (min required 80%)
Details
codecov/project 88.16% (min required 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmccue rmccue deleted the user-role-schema branch Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.