Remove unused prepare_author method from WP_JSON_Posts class #165

Merged
merged 1 commit into from May 4, 2014

Conversation

Projects
None yet
2 participants
@rachelbaker
Member

rachelbaker commented May 3, 2014

Remove unused method: https://github.com/WP-API/WP-API/blob/master/lib/class-wp-json-posts.php#L650

Discussed with @rmccue and agreed that there is no need to depreciate the method since it is a protected, internal-only, method.

@rachelbaker rachelbaker added this to the 1.0 milestone May 3, 2014

@rachelbaker rachelbaker self-assigned this May 3, 2014

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker May 3, 2014

Member

@rmccue #reviewmerge

Member

rachelbaker commented May 3, 2014

@rmccue #reviewmerge

rmccue added a commit that referenced this pull request May 4, 2014

Merge pull request #165 from WP-API/remove-prepare-author
Remove unused prepare_author method from WP_JSON_Posts class

@rmccue rmccue merged commit af213d5 into master May 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rmccue rmccue deleted the remove-prepare-author branch May 4, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue May 4, 2014

Member

Note: still possible BC break for plugins extending this. Will note in upgrade notes.

Member

rmccue commented May 4, 2014

Note: still possible BC break for plugins extending this. Will note in upgrade notes.

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request #165 from WP-API/remove-prepare-author
Remove unused prepare_author method from WP_JSON_Posts class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment