Skip to content
This repository has been archived by the owner. It is now read-only.

Change users schema order to be order of importance instead of alpha #1708

Merged
merged 2 commits into from Nov 9, 2015

Conversation

@rachelbaker
Copy link
Member

commented Oct 31, 2015

No description provided.

@rachelbaker rachelbaker added the Review label Oct 31, 2015
@rachelbaker

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2015

@WP-API/amigos #reviewmerge

@rachelbaker rachelbaker added this to the 2.0 Beta 6 milestone Nov 1, 2015
@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Nov 1, 2015

order of importance

How did you determine this?

@rmccue

This comment has been minimized.

Copy link
Member

commented Nov 2, 2015

👍

@danielbachhuber At a guess, just a design decision.

@rachelbaker

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2015

@danielbachhuber how did you determine the order of the other endpoint schemas?

I moved id to the top and then tried to order the other properties by making educated guesses on likely use.

I can see there are some things I missed here:

  • url should probably move up
  • capabilities and extra_capabilities should be under role and roles

I will refresh this PR when I can.

@rachelbaker rachelbaker added Needs Refresh and removed Review labels Nov 2, 2015
@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Nov 9, 2015

@WP-API/amigos #reviewmerge

I moved url to under email, where it appears in the User Profile in the dashboard. I already see capabilities and extra_capabilities to be under role and roles.

@danielbachhuber danielbachhuber added Review and removed Needs Refresh labels Nov 9, 2015
joehoyle added a commit that referenced this pull request Nov 9, 2015
Change users schema order to be order of importance instead of alpha
@joehoyle joehoyle merged commit 292cef8 into develop Nov 9, 2015
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
codecov/project 92.89% (target 80.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@joehoyle joehoyle deleted the reorder-user-schema branch Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.