Skip to content
This repository has been archived by the owner. It is now read-only.

Prevent PHP error notice when `&filter` isn't an array #1734

Merged
merged 1 commit into from Nov 17, 2015

Conversation

@danielbachhuber
Copy link
Member

danielbachhuber commented Nov 13, 2015

The value is still set if &filter is passed, but array_merge() will
error if $request['filter'] isn't an array.

From #1733

The value is still set if `&filter` is passed, but `array_merge()` will
error if `$request['filter']` isn't an array.
@danielbachhuber

This comment has been minimized.

Copy link
Member Author

danielbachhuber commented Nov 13, 2015

@WP-API/amigos #reviewmerge

danielbachhuber added a commit that referenced this pull request Nov 17, 2015
Only process `filter` when it's an array
@danielbachhuber danielbachhuber merged commit 8001a73 into develop Nov 17, 2015
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
codecov/project 92.75% (target 80.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@danielbachhuber danielbachhuber deleted the 1733-filter-array branch Nov 17, 2015
@danielbachhuber danielbachhuber changed the title Only process `filter` when it's an array Prevent PHP error notice when `filter` isn't an array Nov 18, 2015
@danielbachhuber danielbachhuber changed the title Prevent PHP error notice when `filter` isn't an array Prevent PHP error notice when `&filter` isn't an array Nov 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.