New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent PHP error notice when `&filter` isn't an array #1734

Merged
merged 1 commit into from Nov 17, 2015

Conversation

Projects
None yet
1 participant
@danielbachhuber
Member

danielbachhuber commented Nov 13, 2015

The value is still set if &filter is passed, but array_merge() will
error if $request['filter'] isn't an array.

From #1733

Only process `filter` when it's an array
The value is still set if `&filter` is passed, but `array_merge()` will
error if `$request['filter']` isn't an array.

@danielbachhuber danielbachhuber added this to the 2.0 Beta 7 milestone Nov 13, 2015

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber
Member

danielbachhuber commented Nov 13, 2015

@WP-API/amigos #reviewmerge

danielbachhuber added a commit that referenced this pull request Nov 17, 2015

Merge pull request #1734 from WP-API/1733-filter-array
Only process `filter` when it's an array

@danielbachhuber danielbachhuber merged commit 8001a73 into develop Nov 17, 2015

4 checks passed

Scrutinizer No new issues
Details
codecov/project 92.75% (target 80.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the 1733-filter-array branch Nov 17, 2015

@danielbachhuber danielbachhuber modified the milestones: 2.0 Beta 8, 2.0 Beta 6.1 Nov 18, 2015

@danielbachhuber danielbachhuber changed the title from Only process `filter` when it's an array to Prevent PHP error notice when `filter` isn't an array Nov 18, 2015

@danielbachhuber danielbachhuber changed the title from Prevent PHP error notice when `filter` isn't an array to Prevent PHP error notice when `&filter` isn't an array Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment