Skip to content
This repository has been archived by the owner. It is now read-only.

Bring the wp-api.js library up to date for v2 of the REST API #1828

Merged
merged 1 commit into from Dec 10, 2015

Conversation

@adamsilverstein
Copy link
Contributor

commented Dec 10, 2015

  • Initial pass at bringing the library up to date
  • Correct model endpoints that have changed
  • Verified all models read correctly
  • Verified Post create, read, destroy (trash)
  • Clean up doc block language for models
  • Add additional JSDOC3 Doc Blocks for models
  • rename internal BaseModel to WPApiBaseModel
  • user model defaults to 'me' route if no user id is passed
  • remove slug default from Post model, passing a blank slug was causing Create to fail.
  • Consider eliminating defauls, the api already has defaults?
  • Correct overriding of 'delete', backbone model funciton is destroy
* Initial pass at bringing the library up to date
* Correct model endpoints that have changed
* Verified all models read correctly
* Verified Post create, read, destroy (trash)
* Clean up doc block language for models
* Add additional JSDOC3 Doc Blocks for models
* rename internal BaseModel to WPApiBaseModel
* user model defaults to 'me' route if no user id is passed
* remove slug default from Post model, passing a blank slug was causing Create to fail.
* Consider eliminating defauls, the api already has defaults?
* Correct overriding of 'delete', backbone model funciton is `destroy`
@danielbachhuber danielbachhuber added this to the 2.0 Beta 9 milestone Dec 10, 2015
@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

🚢 🚢

danielbachhuber added a commit that referenced this pull request Dec 10, 2015
Bring the wp-api.js library up to date for v2 of the REST API
@danielbachhuber danielbachhuber merged commit eac563b into develop Dec 10, 2015
4 checks passed
4 checks passed
Scrutinizer 12 new issues
Details
codecov/project 92.93% (target 80.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@danielbachhuber danielbachhuber deleted the fixes/update-wp-api-js-library branch Dec 10, 2015

return WP_API_Settings.root + 'wp/v2/taxonomies/' + this.get( 'taxonomy' ) + '/terms/' + id;
},
urlRoot: WP_API_Settings.root + 'wp/v2/terms/tag',

This comment has been minimized.

Copy link
@joehoyle

joehoyle Dec 10, 2015

Contributor

This will now need updated per #1802

@adamsilverstein

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2015

@joehoyle the js client now traverses the schema to determine models to build, so no update will be required :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.