Fix issues with embedded attachments #194

Merged
merged 2 commits into from May 15, 2014

Conversation

Projects
None yet
2 participants
Owner

rmccue commented May 12, 2014

Fixes #71 by checking that the post supports attachment data before adding it. Also ensures we don't embed entities too far on /media.

rmccue added some commits May 12, 2014

Only add attachment ID on embedded media
This avoids recursion for /media (previously
attachment -> post -> attachment).

@rmccue rmccue added this to the 1.0 milestone May 12, 2014

@rmccue rmccue added the Bug label May 12, 2014

Owner

rmccue commented May 12, 2014

@rachelbaker #reviewmerge

@rmccue rmccue added the Review label May 12, 2014

rachelbaker added a commit that referenced this pull request May 15, 2014

Merge pull request #194 from WP-API/attachment-embedding
Fix issues with embedded attachments

@rachelbaker rachelbaker merged commit 2c39ee9 into master May 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rachelbaker rachelbaker deleted the attachment-embedding branch May 15, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request #194 from WP-API/attachment-embedding
Fix issues with embedded attachments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment