Fourth pass at post meta handler #207

Merged
merged 36 commits into from May 24, 2014

Conversation

Projects
None yet
3 participants
Owner

rmccue commented May 22, 2014

Fixes #68. Continued from #168, #189 based on feedback from the o2.

rmccue added this to the 1.0 milestone May 22, 2014

rmccue self-assigned this May 22, 2014

Owner

rachelbaker commented May 22, 2014

I successfully tested viewing post_meta, adding single value meta keys and values, and editing/adding array values for meta keys.

@tlovett1 would you be able to test this code as well?

Next steps:

  • add functionality docs for post_meta
  • HATEOAS links
Member

tlovett1 commented May 22, 2014

Yes, I'll test.

What if you want to change the meta key but not the value? @rmccue @rachelbaker

Owner

rmccue replied May 22, 2014

Good Q, we should check if $data['value'] is empty and default it. Probably no need to do the same for the key though.

Member

tlovett1 commented May 22, 2014

I tested edit/create/delete. Everything worked well except changing a key without changing the value. Do we have unit tests for this yet?

Owner

rachelbaker commented on 1eee8b9 May 23, 2014

This is just the beginning of the docs needed for the post_meta routes.

Owner

rachelbaker commented May 23, 2014

@rmccue #review 1eee8b9 and 710aac6

Still needed POST /post/ and PUT /post/id post_meta data parameter details. Blocked by merge of #212 that includes data parameter details for those routes.

Owner

rmccue commented May 24, 2014

We're now at 95% minimum code coverage for meta methods; can't test the internal add_post_meta/update_metadata_by_mid/delete_metadata_by_mid responses, since we check for those cases beforehand anyway.

@rachelbaker Can we hit those extra docs in 1.1 instead? If so, let's #reviewmerge and ship 1.0.

@rmccue rmccue assigned rachelbaker and unassigned rmccue May 24, 2014

Owner

rachelbaker commented May 24, 2014

Let's add the extra docs in 1.1, I will review right after breakfast.

On Saturday, May 24, 2014, Ryan McCue notifications@github.com wrote:

We're now at 95% minimum code coverage for meta methods; can't test the
internal add_post_meta/update_metadata_by_mid/delete_metadata_by_midresponses, since we check for those cases beforehand anyway.

@rachelbaker https://github.com/rachelbaker Can we hit those extra docs
in 1.1 instead? If so, let's #reviewmerge and ship 1.0.


Reply to this email directly or view it on GitHubhttps://github.com/WP-API/WP-API/pull/207#issuecomment-44081981
.

Rachel Baker

rachelbaker merged commit b545556 into master May 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

rachelbaker deleted the post-meta-handling-v4 branch May 24, 2014

@kellbot kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

@rachelbaker rachelbaker Added initial pass at docs for post/id/meta GET and POST routes. Rela…
…tes to #213 and #207.
905940e

@kellbot kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

@rachelbaker rachelbaker Added initial pass at docs for post/id/meta/mid GET, PUT and DELETE r…
…outes. Relates to #213 and #207.
f2c250b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment