Fix errors with excerpt #226

Merged
merged 3 commits into from May 29, 2014

Conversation

Projects
None yet
3 participants
Owner

rmccue commented May 27, 2014

Fixes #222.

rmccue added some commits May 27, 2014

Set up and restore post data
Turns out subtle errors turn up if we don't do this. *sigh*
Owner

rmccue commented May 27, 2014

Needs tests and docs.

@rmccue rmccue added this to the 1.1 milestone May 27, 2014

@rmccue rmccue added the Bug label May 27, 2014

@rmccue rmccue self-assigned this May 27, 2014

Owner

rmccue commented May 27, 2014

Tests blocked on #99.

Owner

rmccue commented May 27, 2014

Turns out this is already documented, we must have just removed the docs accidentally.

Owner

rachelbaker commented May 28, 2014

@rmccue is this ready for a #reviewmerge?

Owner

rmccue commented May 28, 2014

@rachelbaker Oh, yes! #reviewmerge :)

@rmccue rmccue added the Review label May 28, 2014

Contributor

kadamwhite commented May 28, 2014

Feels slightly WET, but abstracting the repeated code out may be overkill

Owner

rmccue commented May 29, 2014

Feels slightly WET, but abstracting the repeated code out may be overkill

Indeed, I'm not sure on this one. Surprised there isn't an existing way to do it in WP. (wp_reset_postdata doesn't work here)

Owner

rachelbaker commented May 29, 2014

@rmccue @kadamwhite This does resolve the issue, so I am merging for now. The code can be refactored later in another issue.

rachelbaker added a commit that referenced this pull request May 29, 2014

@rachelbaker rachelbaker merged commit 0b31094 into master May 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rachelbaker rachelbaker deleted the fix-excerpt-errors branch May 29, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment