Allow hijacking requests #281

Merged
merged 6 commits into from Aug 29, 2014

Conversation

Projects
None yet
3 participants
@rmccue
Member

rmccue commented Jun 2, 2014

We should allow hijacking API requests to override the full request (to allow things like caching/etc).

Currently incomplete. While CORS is technically a separate change, it needs the support for OPTIONS, and makes sense to add it now.

Fixes #144.

@rmccue rmccue added this to the 1.2 milestone Jun 2, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jun 3, 2014

Member

@rachelbaker #reviewmerge

Member

rmccue commented Jun 3, 2014

@rachelbaker #reviewmerge

@rmccue rmccue added the Review label Jun 3, 2014

@rmccue rmccue assigned rmccue and unassigned rachelbaker Jun 15, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jun 15, 2014

Member

On me to merge and resolve, post-1.1 release.

Member

rmccue commented Jun 15, 2014

On me to merge and resolve, post-1.1 release.

@rachelbaker rachelbaker removed the Review label Jun 24, 2014

@rmccue rmccue referenced this pull request Jul 3, 2014

Closed

Allow Cross-domain requests #144

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jul 7, 2014

Member

Back to @rachelbaker for #reviewmerge

Member

rmccue commented Jul 7, 2014

Back to @rachelbaker for #reviewmerge

@rmccue rmccue assigned rachelbaker and unassigned rmccue Jul 7, 2014

@rmccue rmccue added the Review label Jul 7, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jul 26, 2014

Member

Refreshed again, @rachelbaker #reviewmerge

Member

rmccue commented Jul 26, 2014

Refreshed again, @rachelbaker #reviewmerge

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Aug 29, 2014

Member

Going to go ahead and merge this before it needs refreshing again. :)

Member

rmccue commented Aug 29, 2014

Going to go ahead and merge this before it needs refreshing again. :)

rmccue added a commit that referenced this pull request Aug 29, 2014

@rmccue rmccue merged commit b9ec595 into master Aug 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rmccue rmccue deleted the allow-hijacking-request branch Aug 29, 2014

@tnguyen14

This comment has been minimized.

Show comment
Hide comment
@tnguyen14

tnguyen14 Nov 16, 2014

@rmccue how could I use this feature to enable CORS? I don't see any doc about CORS on the WP-API website.

@rmccue how could I use this feature to enable CORS? I don't see any doc about CORS on the WP-API website.

@tnguyen14

This comment has been minimized.

Show comment
Hide comment
@tnguyen14

tnguyen14 Nov 16, 2014

Never mind - I think it wasn't working for me because I was on develop branch. Things are working on master.

Never mind - I think it wasn't working for me because I was on develop branch. Things are working on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment