New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split meta endpoints into separate class #358

Merged
merged 19 commits into from Sep 2, 2014

Conversation

Projects
None yet
2 participants
@rmccue
Member

rmccue commented Jul 17, 2014

This is one half of #273.

@rmccue rmccue added this to the 1.2 milestone Jul 17, 2014

@rmccue rmccue added the Enhancement label Jul 17, 2014

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Jul 22, 2014

Member

@rmccue is this ready for a #reviewmerge?

Member

rachelbaker commented Jul 22, 2014

@rmccue is this ready for a #reviewmerge?

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jul 26, 2014

Member

@rachelbaker Hmm. Question is, what's the best way to handle CPTs and extensibility here? Thinking we might want a slight refactor before we merge.

Member

rmccue commented Jul 26, 2014

@rachelbaker Hmm. Question is, what's the best way to handle CPTs and extensibility here? Thinking we might want a slight refactor before we merge.

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Aug 22, 2014

Member

On second thoughts, I'm OK with this.

@rachelbaker #reviewmerge

Member

rmccue commented Aug 22, 2014

On second thoughts, I'm OK with this.

@rachelbaker #reviewmerge

rmccue and others added some commits Aug 29, 2014

Correct fatal error in WP_JSON_Meta_Posts->insert_post_meta().
Undefined method WP_JSON_Meta_Posts::handle_post_meta_action().
Renamed to new class method $this->handle_inline_meta().
Set meta id to an integer when checking against the parent id.
Resolves issue where creating meta for a post_id was returning an error.
Create a new Response object in WP_JSON_Meta_Posts->add_meta().
Resolves PHP warning that Headers were already sent from duplicate use of json_ensure_response on the the same response object.
@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Aug 31, 2014

Member

@rmccue I added some bug fixes for issues discovered during testing. Please #reviewmerge (especially 03faed1)

Member

rachelbaker commented Aug 31, 2014

@rmccue I added some bug fixes for issues discovered during testing. Please #reviewmerge (especially 03faed1)

@rachelbaker rachelbaker assigned rmccue and unassigned rachelbaker Aug 31, 2014

rmccue added a commit that referenced this pull request Sep 2, 2014

Merge pull request #358 from WP-API/split-meta-class
Split meta endpoints into separate class

@rmccue rmccue merged commit 13fde1a into master Sep 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rmccue rmccue deleted the split-meta-class branch Sep 2, 2014

rachelbaker added a commit that referenced this pull request Sep 8, 2014

Revert deprecated handle_post_meta_action() and create handle_get_pos…
…t_meta() method.

Helper methods for post_meta functionality that still occur within Post routes.
First steps to fix functionality break in #358.

@rachelbaker rachelbaker restored the split-meta-class branch Mar 14, 2015

@rachelbaker rachelbaker deleted the split-meta-class branch Oct 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment