New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split comment endpoints into separate class #378

Merged
merged 27 commits into from Oct 26, 2014

Conversation

Projects
None yet
3 participants
@rmccue
Member

rmccue commented Jul 27, 2014

The other half of #273.

@rmccue rmccue added this to the 1.2 milestone Aug 22, 2014

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Sep 2, 2014

Member

@rmccue Shouldn't we move the check_edit_permission() and check_read_permission() methods so they can be accessible within the new split classes? You already duplicated them for the post meta: https://github.com/WP-API/WP-API/blob/master/lib/class-wp-json-meta-posts.php#L24, but it seems silly to do it again.

Related to current Travis error: Call to undefined method WP_JSON_Comments::check_read_permission() in /home/travis/build/WP-API/WP-API/lib/class-wp-json-comments.php on line 85

Member

rachelbaker commented Sep 2, 2014

@rmccue Shouldn't we move the check_edit_permission() and check_read_permission() methods so they can be accessible within the new split classes? You already duplicated them for the post meta: https://github.com/WP-API/WP-API/blob/master/lib/class-wp-json-meta-posts.php#L24, but it seems silly to do it again.

Related to current Travis error: Call to undefined method WP_JSON_Comments::check_read_permission() in /home/travis/build/WP-API/WP-API/lib/class-wp-json-comments.php on line 85

@rachelbaker rachelbaker assigned rmccue and unassigned rachelbaker Sep 2, 2014

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Sep 2, 2014

Member

Kicking back to @rmccue to patch.

Member

rachelbaker commented Sep 2, 2014

Kicking back to @rmccue to patch.

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Sep 19, 2014

Member

This is blocked by #486. Will need to be patched after #486 is merged.

Member

rachelbaker commented Sep 19, 2014

This is blocked by #486. Will need to be patched after #486 is merged.

Japh pushed a commit to Japh/WP-API that referenced this pull request Sep 29, 2014

@whyisjake

This comment has been minimized.

Show comment
Hide comment
@whyisjake

whyisjake Oct 26, 2014

Tested, works for me too...

whyisjake commented Oct 26, 2014

Tested, works for me too...

rachelbaker added a commit that referenced this pull request Oct 26, 2014

Merge pull request #378 from WP-API/split-comment-class
Split comment endpoints into separate class.  Props @whyisjake.

@rachelbaker rachelbaker merged commit 9cbe20b into master Oct 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Oct 26, 2014

Member

Props to @whyisjake for testing!

Member

rachelbaker commented Oct 26, 2014

Props to @whyisjake for testing!

@rachelbaker rachelbaker deleted the split-comment-class branch Oct 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment