New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post 'parent' value should be null rather than zero if unset #391

Merged
merged 1 commit into from Aug 1, 2014

Conversation

Projects
None yet
2 participants
@maxcutler
Contributor

maxcutler commented Aug 1, 2014

Having a field be either an integer or a nested object makes parsing more complicated. Furthermore, knowing that a parent ID of "0" means that a post has no parent is WordPress inside knowledge that should not leak through the API.

post 'parent' value should be null rather than zero if unset
Having a field be either an integer or a nested object makes parsing more complicated. Furthermore, knowing that a parent ID of "0" means that a post has no parent is WordPress inside knowledge that should not leak through the API.

@rmccue rmccue added the Bug label Aug 1, 2014

@rmccue rmccue added this to the 1.2 milestone Aug 1, 2014

@rmccue rmccue self-assigned this Aug 1, 2014

rmccue added a commit that referenced this pull request Aug 1, 2014

Merge pull request #391 from maxcutler/patch-2
post 'parent' value should be null rather than zero if unset

@rmccue rmccue merged commit f50d190 into WP-API:master Aug 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@maxcutler maxcutler deleted the maxcutler:patch-2 branch Aug 1, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request #391 from maxcutler/patch-2
post 'parent' value should be null rather than zero if unset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment