New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing the role parameter to insert_user() method. #335 #392

Merged
merged 1 commit into from Aug 29, 2014

Conversation

Projects
None yet
3 participants
@pippinsplugins
Contributor

pippinsplugins commented Aug 1, 2014

Add support for passing the role parameter to insert_user() method.

This allows users to be created and/or updated with a specific role.

Fixes #335

@rmccue rmccue added this to the 1.2 milestone Aug 21, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Aug 22, 2014

Member

Hmm. Does this allow privilege escalation? If I have the ability to add new users, should I have the ability to give them any role I want?

cc @nacin

Member

rmccue commented Aug 22, 2014

Hmm. Does this allow privilege escalation? If I have the ability to add new users, should I have the ability to give them any role I want?

cc @nacin

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Aug 22, 2014

Member

If you can create users, there's no way to limit which roles you can assign

Member

danielbachhuber commented Aug 22, 2014

If you can create users, there's no way to limit which roles you can assign

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Aug 29, 2014

Member

Cool, works for me.

Member

rmccue commented Aug 29, 2014

Cool, works for me.

rmccue added a commit that referenced this pull request Aug 29, 2014

Merge pull request #392 from WP-API/set-role-with-user
Add support for passing the role parameter to insert_user() method. #335

@rmccue rmccue merged commit ccdec63 into master Aug 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rmccue rmccue deleted the set-role-with-user branch Aug 29, 2014

@rmccue rmccue self-assigned this Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment