New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#347: Added filters to taxonomy based on get_terms args. #401

Merged
merged 2 commits into from Oct 26, 2014

Conversation

Projects
None yet
3 participants
@mauteri
Contributor

mauteri commented Aug 1, 2014

Fixes #347.

@mauteri

This comment has been minimized.

Show comment
Hide comment
@mauteri

mauteri Aug 3, 2014

Contributor

Okay, committed update per @kadamwhite's suggestions. Thx!

Contributor

mauteri commented Aug 3, 2014

Okay, committed update per @kadamwhite's suggestions. Thx!

@kadamwhite

This comment has been minimized.

Show comment
Hide comment
@kadamwhite

kadamwhite Oct 26, 2014

Contributor

This appears to work as advertised, @rmccue. I can provide get_terms filters e.g. filter[number]=10 and get back a list of 10 terms; I can also add a filter on json_tax_query_var-$var (e.g. json_tax_query_var-number) to manipulate the provided filter values.

Contributor

kadamwhite commented Oct 26, 2014

This appears to work as advertised, @rmccue. I can provide get_terms filters e.g. filter[number]=10 and get back a list of 10 terms; I can also add a filter on json_tax_query_var-$var (e.g. json_tax_query_var-number) to manipulate the provided filter values.

@rmccue rmccue added this to the 1.2 milestone Oct 26, 2014

@rmccue rmccue added the Enhancement label Oct 26, 2014

rmccue added a commit that referenced this pull request Oct 26, 2014

Merge pull request #401 from mauteri/347
#347: Added filters to taxonomy based on get_terms args.

@rmccue rmccue merged commit 83dbbad into WP-API:master Oct 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Oct 26, 2014

Member

Sorry for the super long review time on this one, just got time to get back to it with @kadamwhite's help!

Member

rmccue commented Oct 26, 2014

Sorry for the super long review time on this one, just got time to get back to it with @kadamwhite's help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment