New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#409 - Now matches dashes in addition to alphanumeric and _ #410

Merged
merged 6 commits into from Aug 4, 2014

Conversation

Projects
None yet
2 participants
@EdHurtig
Contributor

EdHurtig commented Aug 3, 2014

Added character groups to include \w and hyphens. Thanks to @evansobkowicz for the help.

See Issue #409

@EdHurtig

This comment has been minimized.

Show comment
Hide comment
@EdHurtig

EdHurtig Aug 3, 2014

Contributor

Travis is failing because the route keys were changed and it is trying to assert that the old keys are present, not sure how to / if I can update the unit tests

Contributor

EdHurtig commented Aug 3, 2014

Travis is failing because the route keys were changed and it is trying to assert that the old keys are present, not sure how to / if I can update the unit tests

@EdHurtig

This comment has been minimized.

Show comment
Hide comment
@EdHurtig

EdHurtig Aug 3, 2014

Contributor

Just realized how to run the tests locally... sorry about all the failing commits, I'm a bit new to PHPUnit

Contributor

EdHurtig commented Aug 3, 2014

Just realized how to run the tests locally... sorry about all the failing commits, I'm a bit new to PHPUnit

@rmccue rmccue added this to the 1.2 milestone Aug 3, 2014

@rmccue rmccue added the Bug label Aug 3, 2014

@rmccue rmccue self-assigned this Aug 4, 2014

rmccue added a commit that referenced this pull request Aug 4, 2014

Merge pull request #410 from EdHurtig/master
Match dashes in addition to alphanumeric and underscore

@rmccue rmccue merged commit f15109a into WP-API:master Aug 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment